From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH 1/4] dt-bindings: watchdog: Add i.MX7ULP bindings Date: Fri, 9 Aug 2019 09:42:45 -0700 Message-ID: <20190809164245.GA17136@roeck-us.net> References: <1565334842-28161-1-git-send-email-Anson.Huang@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1565334842-28161-1-git-send-email-Anson.Huang@nxp.com> Sender: linux-kernel-owner@vger.kernel.org To: Anson Huang Cc: wim@linux-watchdog.org, robh+dt@kernel.org, mark.rutland@arm.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux@armlinux.org.uk, otavio@ossystems.com.br, leonard.crestez@nxp.com, schnitzeltony@gmail.com, u.kleine-koenig@pengutronix.de, jan.tuerk@emtrion.com, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Linux-imx@nxp.com List-Id: devicetree@vger.kernel.org On Fri, Aug 09, 2019 at 03:13:59PM +0800, Anson Huang wrote: > Add the watchdog bindings for Freescale i.MX7ULP. > > Signed-off-by: Anson Huang > --- > .../bindings/watchdog/fsl-imx7ulp-wdt.txt | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > create mode 100644 Documentation/devicetree/bindings/watchdog/fsl-imx7ulp-wdt.txt > > diff --git a/Documentation/devicetree/bindings/watchdog/fsl-imx7ulp-wdt.txt b/Documentation/devicetree/bindings/watchdog/fsl-imx7ulp-wdt.txt > new file mode 100644 > index 0000000..d83fc5c > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/fsl-imx7ulp-wdt.txt > @@ -0,0 +1,22 @@ > +* Freescale i.MX7ULP Watchdog Timer (WDT) Controller > + > +Required properties: > +- compatible : Should be "fsl,imx7ulp-wdt" > +- reg : Should contain WDT registers location and length > +- interrupts : Should contain WDT interrupt > +- clocks: Should contain a phandle pointing to the gated peripheral clock. The driver as submitted does not include clock or interrupt handling. Why are those properties listed as mandatory if they are not really needed (nor used) ? > + > +Optional properties: > +- timeout-sec : Contains the watchdog timeout in seconds > + > +Examples: > + > +wdog1: wdog@403d0000 { > + compatible = "fsl,imx7ulp-wdt"; > + reg = <0x403d0000 0x10000>; > + interrupts = ; > + clocks = <&pcc2 IMX7ULP_CLK_WDG1>; > + assigned-clocks = <&pcc2 IMX7ULP_CLK_WDG1>; > + assigned-clocks-parents = <&scg1 IMX7ULP_CLK_FIRC_BUS_CLK>; > + timeout-sec = <40>; > +}; > -- > 2.7.4 >