From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: robh+dt@kernel.org, kernel@pengutronix.de,
linux-input@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/4] Input: ads7846 - convert to devm_ alloc functions
Date: Fri, 9 Aug 2019 09:44:31 -0700 [thread overview]
Message-ID: <20190809164431.GL178933@dtor-ws> (raw)
In-Reply-To: <20190327133927.1340-2-m.felsch@pengutronix.de>
On Wed, Mar 27, 2019 at 02:39:24PM +0100, Marco Felsch wrote:
> Convert to devm function to drop the 'no-mem' error handling path and
> strip down the remove funciton a bit.
>
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
I am not fond of partial devm conversions, as this causes reordering in
of freeing resources in unwind path. In this particular case input
device will be unregistered only after majority of the driver structure
is torn down.
If we want to do devm conversion, we need to do a complete one.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2019-08-09 16:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 13:39 [PATCH 0/4] ADS7846 add general touchscreen features Marco Felsch
2019-03-27 13:39 ` [PATCH 1/4] Input: ads7846 - convert to devm_ alloc functions Marco Felsch
2019-08-09 16:44 ` Dmitry Torokhov [this message]
2019-03-27 13:39 ` [PATCH 2/4] dt-bindings: input: ads7846: fix property description Marco Felsch
[not found] ` <5ca06164.1c69fb81.39fb3.79f9@mx.google.com>
2019-08-09 16:42 ` Dmitry Torokhov
2019-03-27 13:39 ` [PATCH 3/4] dt-bindings: input: ads7846: replace vendor-bindings by general ones Marco Felsch
[not found] ` <5ca06167.1c69fb81.6e121.c248@mx.google.com>
2019-08-21 7:36 ` Marco Felsch
2019-08-22 17:44 ` Dmitry Torokhov
2019-03-27 13:39 ` [PATCH 4/4] Input: ads7846 - add support for general touchscreen bindings Marco Felsch
2019-08-09 16:42 ` Dmitry Torokhov
2019-08-09 9:30 ` [PATCH 0/4] ADS7846 add general touchscreen features Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190809164431.GL178933@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-input@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).