From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH] at91/dt: ariettag25: style cleanup Date: Mon, 12 Aug 2019 16:57:02 +0200 Message-ID: <20190812145702.GO3600@piout.net> References: <20190731220045.3992-1-uwe@kleine-koenig.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <20190731220045.3992-1-uwe@kleine-koenig.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Mark Rutland , devicetree@vger.kernel.org, Ludovic Desroches , Rob Herring , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org Hi, The subject prefix should be "ARM: dts: at91:" On 01/08/2019 00:00:45+0200, Uwe Kleine-K=F6nig wrote: > - newline between properties and sub-nodes > - use tags from included dtsi instead of duplicating the hierarchy > - status should be the last property > - drop duplicated alias > = > There are no differences in the generated .dtb > = > Signed-off-by: Uwe Kleine-K=F6nig > --- > Hello, > = > these are the style rules I was teached when modifying imx dts files. > Do they apply to at91, too? > = > Best regards > Uwe > = > arch/arm/boot/dts/at91-ariettag25.dts | 87 +++++++++++++-------------- > 1 file changed, 43 insertions(+), 44 deletions(-) > = > diff --git a/arch/arm/boot/dts/at91-ariettag25.dts b/arch/arm/boot/dts/at= 91-ariettag25.dts > index 7a34c4dc05d2..8f9f5a22cbf6 100644 > --- a/arch/arm/boot/dts/at91-ariettag25.dts > +++ b/arch/arm/boot/dts/at91-ariettag25.dts > @@ -6,14 +6,11 @@ > */ > /dts-v1/; > #include "at91sam9g25.dtsi" > + > / { > model =3D "Acme Systems Arietta G25"; > compatible =3D "acme,ariettag25", "atmel,at91sam9x5", "atmel,at91sam9"; > = > - aliases { > - serial0 =3D &dbgu; > - }; > - > chosen { > stdout-path =3D "serial0:115200n8"; > }; > @@ -34,55 +31,16 @@ > = > ahb { > apb { > - mmc0: mmc@f0008000 { > - pinctrl-0 =3D < > - &pinctrl_mmc0_slot0_clk_cmd_dat0 > - &pinctrl_mmc0_slot0_dat1_3>; > - status =3D "okay"; > - > - slot@0 { > - reg =3D <0>; > - bus-width =3D <4>; > - }; > - }; > - > - tcb0: timer@f8008000 { > - timer@0 { > - compatible =3D "atmel,tcb-timer"; > - reg =3D <0>; > - }; > - > - timer@1 { > - compatible =3D "atmel,tcb-timer"; > - reg =3D <1>; > - }; > - }; > - > - usb2: gadget@f803c000 { > - status =3D "okay"; > - }; > - > - dbgu: serial@fffff200 { > - status =3D "okay"; > - }; > - > rtc@fffffeb0 { You can had a label to the rtc in a preliminary patch so you can remove the hierarchy. > status =3D "okay"; > }; > }; > = > - usb0: ohci@600000 { > - status =3D "okay"; > - num-ports =3D <3>; > - }; > - > - usb1: ehci@700000 { > - status =3D "okay"; > - }; > }; > = > leds { > compatible =3D "gpio-leds"; > + > arietta_led { > label =3D "arietta_led"; > gpios =3D <&pioB 8 GPIO_ACTIVE_HIGH>; /* PB8 */ > @@ -90,3 +48,44 @@ > }; > }; > }; > + > +&dbgu { > + status =3D "okay"; > +}; > + > +&mmc0 { > + pinctrl-0 =3D < > + &pinctrl_mmc0_slot0_clk_cmd_dat0 > + &pinctrl_mmc0_slot0_dat1_3>; > + status =3D "okay"; > + > + slot@0 { > + reg =3D <0>; > + bus-width =3D <4>; > + }; > +}; > + > +&tcb0 { > + timer@0 { > + compatible =3D "atmel,tcb-timer"; > + reg =3D <0>; > + }; > + > + timer@1 { > + compatible =3D "atmel,tcb-timer"; > + reg =3D <1>; > + }; > +}; > + > +&usb0 { > + num-ports =3D <3>; > + status =3D "okay"; > +}; > + > +&usb1 { > + status =3D "okay"; > +}; > + > +&usb2 { > + status =3D "okay"; > +}; > -- = > 2.20.1 > = -- = Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com