From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH v1 2/3] arm64: dts: fix gpio node Date: Mon, 12 Aug 2019 17:27:25 +0200 Message-ID: <20190812152723.GK27041@X250> References: <20190808101628.36782-1-hui.song_1@nxp.com> <20190808101628.36782-2-hui.song_1@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190808101628.36782-2-hui.song_1@nxp.com> Sender: linux-kernel-owner@vger.kernel.org To: Hui Song Cc: Li Yang , Rob Herring , Mark Rutland , Linus Walleij , Bartosz Golaszewski , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org List-Id: devicetree@vger.kernel.org On Thu, Aug 08, 2019 at 06:16:27PM +0800, Hui Song wrote: > From: Song Hui > > Update the nodes to include little-endian > property to be consistent with the hardware > and add ls1088a gpio specify compatible. > > Signed-off-by: Song Hui The prefix should be more specific, like 'arm64: dts: ls1088a: ...' Shawn > --- > arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > index 20f5ebd..d58d203 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > @@ -269,43 +269,47 @@ > }; > > gpio0: gpio@2300000 { > - compatible = "fsl,qoriq-gpio"; > + compatible = "fsl,ls1088a-gpio", "fsl,qoriq-gpio"; > reg = <0x0 0x2300000 0x0 0x10000>; > interrupts = <0 36 IRQ_TYPE_LEVEL_HIGH>; > gpio-controller; > #gpio-cells = <2>; > interrupt-controller; > #interrupt-cells = <2>; > + little-endian; > }; > > gpio1: gpio@2310000 { > - compatible = "fsl,qoriq-gpio"; > + compatible = "fsl,ls1088a-gpio", "fsl,qoriq-gpio"; > reg = <0x0 0x2310000 0x0 0x10000>; > interrupts = <0 36 IRQ_TYPE_LEVEL_HIGH>; > gpio-controller; > #gpio-cells = <2>; > interrupt-controller; > #interrupt-cells = <2>; > + little-endian; > }; > > gpio2: gpio@2320000 { > - compatible = "fsl,qoriq-gpio"; > + compatible = "fsl,ls1088a-gpio", "fsl,qoriq-gpio"; > reg = <0x0 0x2320000 0x0 0x10000>; > interrupts = <0 37 IRQ_TYPE_LEVEL_HIGH>; > gpio-controller; > #gpio-cells = <2>; > interrupt-controller; > #interrupt-cells = <2>; > + little-endian; > }; > > gpio3: gpio@2330000 { > - compatible = "fsl,qoriq-gpio"; > + compatible = "fsl,ls1088a-gpio", "fsl,qoriq-gpio"; > reg = <0x0 0x2330000 0x0 0x10000>; > interrupts = <0 37 IRQ_TYPE_LEVEL_HIGH>; > gpio-controller; > #gpio-cells = <2>; > interrupt-controller; > #interrupt-cells = <2>; > + little-endian; > }; > > ifc: ifc@2240000 { > -- > 2.9.5 >