* [PATCH] ARM: dts: am335x-wega.dtsi: fix wrong card detect pin level
@ 2019-07-09 18:32 Andreas Klinger
2019-07-22 8:06 ` Teresa Remmet
2019-08-13 10:17 ` Tony Lindgren
0 siblings, 2 replies; 3+ messages in thread
From: Andreas Klinger @ 2019-07-09 18:32 UTC (permalink / raw)
To: linux-omap
Cc: bcousson, tony, robh+dt, mark.rutland, devicetree, linux-kernel
mmc cards on mmc1 are not detected because of wrong card detect (cd) level.
Change cd from GPIO_ACTIVE_HIGH to GPIO_ACTIVE_LOW.
This is necessary because of commit e63201f19438 ("mmc: omap_hsmmc:
Delete platform data GPIO CD and WP")
Signed-off-by: Andreas Klinger <ak@it-klinger.de>
---
arch/arm/boot/dts/am335x-wega.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/am335x-wega.dtsi b/arch/arm/boot/dts/am335x-wega.dtsi
index b7d28a20341f..84581fed3d06 100644
--- a/arch/arm/boot/dts/am335x-wega.dtsi
+++ b/arch/arm/boot/dts/am335x-wega.dtsi
@@ -157,7 +157,7 @@
bus-width = <4>;
pinctrl-names = "default";
pinctrl-0 = <&mmc1_pins>;
- cd-gpios = <&gpio0 6 GPIO_ACTIVE_HIGH>;
+ cd-gpios = <&gpio0 6 GPIO_ACTIVE_LOW>;
status = "okay";
};
--
2.11.0
--
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: am335x-wega.dtsi: fix wrong card detect pin level
2019-07-09 18:32 [PATCH] ARM: dts: am335x-wega.dtsi: fix wrong card detect pin level Andreas Klinger
@ 2019-07-22 8:06 ` Teresa Remmet
2019-08-13 10:17 ` Tony Lindgren
1 sibling, 0 replies; 3+ messages in thread
From: Teresa Remmet @ 2019-07-22 8:06 UTC (permalink / raw)
To: Andreas Klinger, linux-omap
Cc: bcousson, tony, robh+dt, mark.rutland, devicetree, linux-kernel
Hello Andreas,
Am Dienstag, den 09.07.2019, 20:32 +0200 schrieb Andreas Klinger:
> mmc cards on mmc1 are not detected because of wrong card detect (cd)
> level.
>
> Change cd from GPIO_ACTIVE_HIGH to GPIO_ACTIVE_LOW.
>
> This is necessary because of commit e63201f19438 ("mmc: omap_hsmmc:
> Delete platform data GPIO CD and WP")
Thanks for noticing. But the fix is already in master.
Teresa
>
> Signed-off-by: Andreas Klinger <ak@it-klinger.de>
> ---
> arch/arm/boot/dts/am335x-wega.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/am335x-wega.dtsi
> b/arch/arm/boot/dts/am335x-wega.dtsi
> index b7d28a20341f..84581fed3d06 100644
> --- a/arch/arm/boot/dts/am335x-wega.dtsi
> +++ b/arch/arm/boot/dts/am335x-wega.dtsi
> @@ -157,7 +157,7 @@
> bus-width = <4>;
> pinctrl-names = "default";
> pinctrl-0 = <&mmc1_pins>;
> - cd-gpios = <&gpio0 6 GPIO_ACTIVE_HIGH>;
> + cd-gpios = <&gpio0 6 GPIO_ACTIVE_LOW>;
> status = "okay";
> };
>
> --
> 2.11.0
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: am335x-wega.dtsi: fix wrong card detect pin level
2019-07-09 18:32 [PATCH] ARM: dts: am335x-wega.dtsi: fix wrong card detect pin level Andreas Klinger
2019-07-22 8:06 ` Teresa Remmet
@ 2019-08-13 10:17 ` Tony Lindgren
1 sibling, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2019-08-13 10:17 UTC (permalink / raw)
To: Andreas Klinger
Cc: linux-omap, bcousson, robh+dt, mark.rutland, devicetree,
linux-kernel
* Andreas Klinger <ak@it-klinger.de> [190709 11:32]:
> mmc cards on mmc1 are not detected because of wrong card detect (cd) level.
>
> Change cd from GPIO_ACTIVE_HIGH to GPIO_ACTIVE_LOW.
>
> This is necessary because of commit e63201f19438 ("mmc: omap_hsmmc:
> Delete platform data GPIO CD and WP")
>
> Signed-off-by: Andreas Klinger <ak@it-klinger.de>
> ---
> arch/arm/boot/dts/am335x-wega.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/am335x-wega.dtsi b/arch/arm/boot/dts/am335x-wega.dtsi
> index b7d28a20341f..84581fed3d06 100644
> --- a/arch/arm/boot/dts/am335x-wega.dtsi
> +++ b/arch/arm/boot/dts/am335x-wega.dtsi
> @@ -157,7 +157,7 @@
> bus-width = <4>;
> pinctrl-names = "default";
> pinctrl-0 = <&mmc1_pins>;
> - cd-gpios = <&gpio0 6 GPIO_ACTIVE_HIGH>;
> + cd-gpios = <&gpio0 6 GPIO_ACTIVE_LOW>;
> status = "okay";
> };
>
Looks like this already got fixed with an earlier commit 8a0098c05a27
("ARM: dts: am335x phytec boards: Fix cd-gpios active level").
Regards,
Tony
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-13 10:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-09 18:32 [PATCH] ARM: dts: am335x-wega.dtsi: fix wrong card detect pin level Andreas Klinger
2019-07-22 8:06 ` Teresa Remmet
2019-08-13 10:17 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).