From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH 03/22] arm64: dts: qcom: sm8150: add tlmm node Date: Wed, 14 Aug 2019 10:01:04 -0700 Message-ID: <20190814170105.027C42063F@mail.kernel.org> References: <20190814125012.8700-1-vkoul@kernel.org> <20190814125012.8700-4-vkoul@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20190814125012.8700-4-vkoul@kernel.org> Sender: linux-kernel-owner@vger.kernel.org To: Andy Gross Cc: linux-arm-msm@vger.kernel.org, Bjorn Andersson , sibis@codeaurora.org, Vinod Koul , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org Quoting Vinod Koul (2019-08-14 05:49:53) > Signed-off-by: Vinod Koul > --- Add some commit text? Or just squash with the first patch? Not sure why it's a different commit. > arch/arm64/boot/dts/qcom/sm8150.dtsi | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) >=20 > diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/q= com/sm8150.dtsi > index cd9fcadaeacb..5f2f21270e2d 100644 > --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi > @@ -189,6 +189,21 @@ > }; > }; > =20 > + tlmm: pinctrl@3100000 { > + compatible =3D "qcom,sm8150-pinctrl"; > + reg =3D <0x03100000 0x300000>, > + <0x03500000 0x300000>, > + <0x03900000 0x300000>, > + <0x03D00000 0x300000>; Please don't use capitalized hex characters. > + reg-names =3D "west", "east", "north", "south"; > + interrupts =3D ; > + gpio-ranges =3D <&tlmm 0 0 175>; > + gpio-controller; > + #gpio-cells =3D <2>; > + interrupt-controller; > + #interrupt-cells =3D <2>; > + }; > +