From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bhushan Shah Subject: Re: [PATCH v2 2/3] arm64: allwinner: h6: add I2C nodes Date: Fri, 16 Aug 2019 13:53:11 +0530 Message-ID: <20190816082311.GB18236@pyxis> References: <20190811090503.32396-1-bshah@kde.org> <20190816064710.18280-1-bshah@kde.org> <20190816064710.18280-3-bshah@kde.org> <20190816075031.zw4bjunn4hfoaq3e@flea> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Pd0ReVV5GZGQvF3a" Return-path: Content-Disposition: inline In-Reply-To: <20190816075031.zw4bjunn4hfoaq3e@flea> Sender: linux-kernel-owner@vger.kernel.org To: Maxime Ripard Cc: Bhushan Shah , Icenowy Zheng , Rob Herring , Mark Rutland , Chen-Yu Tsai , Wolfram Sang , Gregory CLEMENT , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org --Pd0ReVV5GZGQvF3a Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 16, 2019 at 09:50:31AM +0200, Maxime Ripard wrote: > On Fri, Aug 16, 2019 at 12:17:09PM +0530, Bhushan Shah wrote: > > Add device-tree nodes for i2c0 to i2c2, and also add relevant pinctrl > > nodes. > > > > Suggested-by: Icenowy Zheng > > Signed-off-by: Bhushan Shah > > --- > > Changes in v2: > > - Add the SoC specific compatible string instead of re-using a31 one. > > > > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 56 +++++++++++++++++++- > > 1 file changed, 55 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/= boot/dts/allwinner/sun50i-h6.dtsi > > index bcecca17d61d..a1a329926540 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > @@ -329,6 +329,21 @@ > > function =3D "hdmi"; > > }; > > > > + i2c0_pins: i2c0-pins { > > + pins =3D "PD25", "PD26"; > > + function =3D "i2c0"; > > + }; > > + > > + i2c1_pins: i2c1-pins { > > + pins =3D "PH5", "PH6"; > > + function =3D "i2c1"; > > + }; > > + > > + i2c2_pins: i2c2-pins { > > + pins =3D "PD23", "PD24"; > > + function =3D "i2c2"; > > + }; > > + > > mmc0_pins: mmc0-pins { > > pins =3D "PF0", "PF1", "PF2", "PF3", > > "PF4", "PF5"; > > @@ -464,6 +479,45 @@ > > status =3D "disabled"; > > }; > > > > + i2c0: i2c@5002000 { > > + compatible =3D "allwinner,sun50i-h6-i2c"; >=20 > This isn't going to work if you don't patch the driver to add the > compatible. And this isn't what you described in the binding patch. oops, I will correct this in next patch series. Sorry. >=20 > Maxime >=20 > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com --=20 Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D --Pd0ReVV5GZGQvF3a Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEs8s2ZVJUC+Bu6a2XEZaMRJKMrvwFAl1WZ+4ACgkQEZaMRJKM rvxqAQgAjTTOPqp4IbGW4/nDm8BBmNiePwfg57R8R49Uy4uEW2aWag5VAObJy66F cWkU8CtYUYXWPvnke18zDyH+EqqgJgraUnNyU1Slj3e6kylEvREKRsM4W9u8m4ti r88PZiTtWmPLmAYOrzIUVckEwDau21Apeqjf1+Tqq2Q3xCGx2vRPBsm59972SGVY yT8k1SWABM5m42rko8rQh+XZ9u0niBliD1u4+KY8zQ9Uu/g8T/t7JcCu+ysy8U+W esnMrLdwMChMpjDzAX1vdkAexCAo5E6/NeDbcQWJqxjqCDX5oy/vIXlydKl1Sczx DrysSQzkyw8rbwv9OGMC+YtpVHjAYA== =gJ/S -----END PGP SIGNATURE----- --Pd0ReVV5GZGQvF3a--