From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH] ath10k: Fix HOST capability QMI incompatibility Date: Fri, 16 Aug 2019 16:11:41 -0500 Message-ID: <20190816211141.GA4468@bogus> References: <20190725063108.15790-1-bjorn.andersson@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190725063108.15790-1-bjorn.andersson@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: Bjorn Andersson Cc: Kalle Valo , "David S. Miller" , Mark Rutland , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, stable@vger.kernel.org List-Id: devicetree@vger.kernel.org On Wed, Jul 24, 2019 at 11:31:08PM -0700, Bjorn Andersson wrote: > The introduction of 768ec4c012ac ("ath10k: update HOST capability QMI > message") served the purpose of supporting the new and extended HOST > capability QMI message. > > But while the new message adds a slew of optional members it changes the > data type of the "daemon_support" member, which means that older > versions of the firmware will fail to decode the incoming request > message. > > There is no way to detect this breakage from Linux and there's no way to > recover from sending the wrong message (i.e. we can't just try one > format and then fallback to the other), so a quirk is introduced in > DeviceTree to indicate to the driver that the firmware requires the 8bit > version of this message. > > Cc: stable@vger.kernel.org > Fixes: 768ec4c012ac ("ath10k: update HOST capability qmi message") > Signed-off-by: Bjorn Andersson > --- > .../bindings/net/wireless/qcom,ath10k.txt | 6 +++++ Acked-by: Rob Herring > drivers/net/wireless/ath/ath10k/qmi.c | 13 ++++++++--- > .../net/wireless/ath/ath10k/qmi_wlfw_v01.c | 22 +++++++++++++++++++ > .../net/wireless/ath/ath10k/qmi_wlfw_v01.h | 1 + > drivers/net/wireless/ath/ath10k/snoc.c | 11 ++++++++++ > drivers/net/wireless/ath/ath10k/snoc.h | 1 + > 6 files changed, 51 insertions(+), 3 deletions(-)