From: Maxime Ripard <mripard@kernel.org>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
devicetree <devicetree@vger.kernel.org>
Subject: Re: [PATCH 5/5] ARM: dts: sunxi: Add missing watchdog interrupts
Date: Mon, 19 Aug 2019 19:51:43 +0200 [thread overview]
Message-ID: <20190819175143.g5hilveoeubkbfpk@flea> (raw)
In-Reply-To: <CAGb2v66C-Mqdo-xWm4RAw33sFk-gLy-L_YWQ__6BjYU9gcpYug@mail.gmail.com>
On Wed, Aug 14, 2019 at 12:44:02PM +0800, Chen-Yu Tsai wrote:
> On Tue, Aug 13, 2019 at 8:48 PM Maxime Ripard <mripard@kernel.org> wrote:
> >
> > From: Maxime Ripard <maxime.ripard@bootlin.com>
> >
> > The watchdog has an interrupt on all our SoCs, but it wasn't always listed.
> > Add it to the devicetree where it's missing.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
>
> Acked-by: Chen-Yu Tsai <wens@csie.org>
>
> On a separate note, the A31 has four watchdogs in the timer block, and
> one interrupt for each watchdog. Should we expand the node to encompass
> all of them, or add separate nodes for each additional one?
Yep, I guess that's the idea considering the register range.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-08-19 17:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 12:47 [PATCH 1/5] dt-bindings: mfd: Convert Allwinner GPADC bindings to a schema Maxime Ripard
2019-08-13 12:47 ` [PATCH 2/5] dt-bindings: watchdog: Convert Allwinner watchdog " Maxime Ripard
2019-08-13 21:30 ` Rob Herring
2019-08-13 12:47 ` [PATCH 3/5] dt-bindings: watchdog: sun4i: Add the watchdog interrupts Maxime Ripard
2019-08-13 21:32 ` Rob Herring
2019-08-13 12:47 ` [PATCH 4/5] ARM: dts: sun8i: a83t: Remove the watchdog clock Maxime Ripard
2019-08-14 4:38 ` Chen-Yu Tsai
2019-08-13 12:47 ` [PATCH 5/5] ARM: dts: sunxi: Add missing watchdog interrupts Maxime Ripard
2019-08-14 4:44 ` Chen-Yu Tsai
2019-08-19 17:51 ` Maxime Ripard [this message]
2019-08-13 21:28 ` [PATCH 1/5] dt-bindings: mfd: Convert Allwinner GPADC bindings to a schema Rob Herring
2019-08-19 18:27 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190819175143.g5hilveoeubkbfpk@flea \
--to=mripard@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox