Re: [PATCH 08/22] arm64: dts: qcom: pm8150: Add vadc node

Stephen Boyd
2019-08-14T17:05:17Z

Quoting Vinod Koul (2019-08-14 05:49:58)
> @@ -25,6 +26,33 @@
> };
> };
>
> + pm8150_adc: adc@3100 {
> + compatible = "qcom,spmi-adc5";
> + reg = <0x3100>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + #io-channel-cells = <1>;
> + interrupts = <0x0 0x31 0x0 IRQ_TYPE_EDGE_RISING>;

status = "disabled"? I imagine there are cases where some board doesn't
want to use the ADC for anything.

> +
> + ref-gnd@0 {
> + reg = <ADC5_REF_GND>;
> + qcom,pre-scaling = <1 1>;
> + label = "ref_gnd";
> + };
> +
> + vref-1p25@1 {
> + reg = <ADC5_1P25VREF>;
> + qcom,pre-scaling = <1 1>;
> + label = "vref_1p25";
> + };
> +
> + die-temp@6 {
> + reg = <ADC5_DIE_TEMP>;
> + qcom,pre-scaling = <1 1>;
> + label = "die_temp";
> + };

Are these board level details?

> + };
> +
> rtc@6000 {
> compatible = "qcom,pm8941-rtc";
> reg = <0x6000>;
> --
> 2.20.1
>