From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Sam Shih <sam.shih@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Ryder Lee <ryder.lee@mediatek.com>,
John Crispin <john@phrozen.org>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v4 2/10] pwm: mediatek: droping the check for of_device_get_match_data
Date: Tue, 20 Aug 2019 07:40:57 +0200 [thread overview]
Message-ID: <20190820054057.xtbhtjm65f6rphcg@pengutronix.de> (raw)
In-Reply-To: <1566265225-27452-3-git-send-email-sam.shih@mediatek.com>
Hello,
On Tue, Aug 20, 2019 at 09:40:17AM +0800, Sam Shih wrote:
> From: sam shih <sam.shih@mediatek.com>
Your Signed-off-by and the mail's From uses capital letters. Can you
please make them all match?
> This patch drop the check for of_device_get_match_data.
> Due to the only way call driver probe is compatible match,
> In this case, the platform data should never be NULL.
Yeah, all entries in the of_match_table have a .data pointer.
Theoretically the driver could be bound by driver.name and then
of_device_get_match_data returns NULL.
It's still ok to drop this check if you want to, I just want to make
sure this possibility is known.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2019-08-20 5:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 1:40 [PATCH v4 0/10] Add mt7629 and fix mt7628 pwm Sam Shih
2019-08-20 1:40 ` [PATCH v4 1/10] pwm: mediatek: add a property "num-pwms" Sam Shih
2019-08-20 5:32 ` Uwe Kleine-König
2019-08-20 1:40 ` [PATCH v4 2/10] pwm: mediatek: droping the check for of_device_get_match_data Sam Shih
2019-08-20 5:40 ` Uwe Kleine-König [this message]
2019-08-20 1:40 ` [PATCH v4 3/10] pwm: mediatek: allocate the clks array dynamically and fix mt7628 pwm Sam Shih
2019-08-20 5:51 ` Uwe Kleine-König
2019-08-20 1:40 ` [PATCH v4 4/10] pwm: mediatek: use pwm_mediatek as common prefix Sam Shih
2019-08-20 5:55 ` Uwe Kleine-König
2019-08-20 1:40 ` [PATCH v4 5/10] dt-bindings: pwm: add a property "num-pwms" Sam Shih
2019-08-20 5:56 ` Uwe Kleine-König
2019-08-20 1:40 ` [PATCH v4 6/10] dt-bindings: pwm: update bindings for MT7628 SoC Sam Shih
2019-08-20 5:58 ` Uwe Kleine-König
2019-08-20 1:40 ` [PATCH v4 7/10] arm64: dts: mt7622: add a property "num-pwms" for PWM node Sam Shih
2019-08-20 1:40 ` [PATCH v4 8/10] arm: dts: mt7623: " Sam Shih
2019-08-20 1:40 ` [PATCH v4 9/10] dt-bindings: pwm: update bindings for MT7629 SoC Sam Shih
2019-08-20 18:00 ` Rob Herring
2019-08-20 1:40 ` [PATCH v4 10/10] arm: dts: mediatek: add mt7629 pwm support Sam Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190820054057.xtbhtjm65f6rphcg@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=ryder.lee@mediatek.com \
--cc=sam.shih@mediatek.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).