From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v2 2/4] nvmem: meson-efuse: bindings: Add secure-monitor phandle Date: Wed, 21 Aug 2019 13:14:58 -0500 Message-ID: <20190821181458.GA2886@bogus> References: <20190731082339.20163-1-ccaione@baylibre.com> <20190731082339.20163-3-ccaione@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20190731082339.20163-3-ccaione@baylibre.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Carlo Caione Cc: devicetree@vger.kernel.org, narmstrong@baylibre.com, khilman@baylibre.com, srinivas.kandagatla@linaro.org, linux-amlogic@lists.infradead.org, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, jbrunet@baylibre.com List-Id: devicetree@vger.kernel.org On Wed, Jul 31, 2019 at 09:23:37AM +0100, Carlo Caione wrote: > Add a new property to link the nvmem driver to the secure-monitor. The > nvmem driver needs to access the secure-monitor to be able to access the > fuses. > > Signed-off-by: Carlo Caione > --- > Documentation/devicetree/bindings/nvmem/amlogic-efuse.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/nvmem/amlogic-efuse.txt b/Documentation/devicetree/bindings/nvmem/amlogic-efuse.txt > index 2e0723ab3384..f7b3ed74db54 100644 > --- a/Documentation/devicetree/bindings/nvmem/amlogic-efuse.txt > +++ b/Documentation/devicetree/bindings/nvmem/amlogic-efuse.txt > @@ -4,6 +4,7 @@ Required properties: > - compatible: should be "amlogic,meson-gxbb-efuse" > - clocks: phandle to the efuse peripheral clock provided by the > clock controller. > +- secure-monitor: phandle to the secure-monitor node > > = Data cells = > Are child nodes of eFuse, bindings of which as described in > @@ -16,6 +17,7 @@ Example: > clocks = <&clkc CLKID_EFUSE>; > #address-cells = <1>; > #size-cells = <1>; > + secure-monitor = <&sm>; > > sn: sn@14 { > reg = <0x14 0x10>; > @@ -30,6 +32,10 @@ Example: > }; > }; > > + sm: secure-monitor { > + compatible = "amlogic,meson-gxbb-sm"; > + }; I guess I acked this a while back, but I'm not sure I would today. It seems incomplete and a node with only a compatible string and no resources doesn't need to be in DT. But that's already done... There's no need for 'secure-monitor' anyways. Just do 'of_find_compatible_node(NULL, NULL, "amlogic,meson-gxbb-sm")' or search for the driver directly. It's not like there's more than one secure monitor... Rob