From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v4 05/10] ARM: dts: sunxi: a80: Add msgbox node Date: Fri, 23 Aug 2019 16:56:21 +0200 Message-ID: <20190823145621.pxl4jrux7izflzmg@flea> References: <20190820032311.6506-1-samuel@sholland.org> <20190820032311.6506-6-samuel@sholland.org> <20190820081528.7g2lo4njkut5lanu@flea> Reply-To: maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="c4vbgluuko4stj5s" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Samuel Holland Cc: Chen-Yu Tsai , Jassi Brar , Michael Turquette , Stephen Boyd , Rob Herring , Mark Rutland , Corentin Labbe , Vasily Khoruzhick , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org --c4vbgluuko4stj5s Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Hi, On Tue, Aug 20, 2019 at 08:17:49AM -0500, Samuel Holland wrote: > On 8/20/19 3:15 AM, Maxime Ripard wrote: > > On Mon, Aug 19, 2019 at 10:23:06PM -0500, Samuel Holland wrote: > >> The A80 SoC contains a message box that can be used to send messages and > >> interrupts back and forth between the ARM application CPUs and the ARISC > >> coprocessor. Add a device tree node for it. > >> > >> Signed-off-by: Samuel Holland > > > > I think you mentionned that crust has been tested only on the A64 and > > the H3/H5, did you test the mailbox on those other SoCs as well? > > No, I only have A64/H3/H5, and recently H6, hardware to test. I've looked > through the manuals to verify that the registers are all the same, but I haven't > run the driver on earlier SoCs. I'd rather not merge them until they've been properly tested. We've had some surprises with the documentation in the past :/ Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --c4vbgluuko4stj5s--