From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v2 04/10] dt-bindings: pci: layerscape-pci: add compatible strings for ls1088a and ls2088a Date: Tue, 27 Aug 2019 17:26:18 -0500 Message-ID: <20190827222617.GA16361@bogus> References: <20190822112242.16309-1-xiaowei.bao@nxp.com> <20190822112242.16309-4-xiaowei.bao@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190822112242.16309-4-xiaowei.bao@nxp.com> Sender: linux-kernel-owner@vger.kernel.org To: Xiaowei Bao Cc: bhelgaas@google.com, mark.rutland@arm.com, shawnguo@kernel.org, leoyang.li@nxp.com, kishon@ti.com, lorenzo.pieralisi@arm.co, arnd@arndb.de, gregkh@linuxfoundation.org, minghuan.Lian@nxp.com, mingkai.hu@nxp.com, roy.zang@nxp.com, jingoohan1@gmail.com, gustavo.pimentel@synopsys.com, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, andrew.murray@arm.com List-Id: devicetree@vger.kernel.org On Thu, Aug 22, 2019 at 07:22:36PM +0800, Xiaowei Bao wrote: > Add compatible strings for ls1088a and ls2088a. > > Signed-off-by: Xiaowei Bao > --- > v2: > - No change. > > Documentation/devicetree/bindings/pci/layerscape-pci.txt | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pci/layerscape-pci.txt b/Documentation/devicetree/bindings/pci/layerscape-pci.txt > index e20ceaa..16f592e 100644 > --- a/Documentation/devicetree/bindings/pci/layerscape-pci.txt > +++ b/Documentation/devicetree/bindings/pci/layerscape-pci.txt > @@ -22,7 +22,10 @@ Required properties: > "fsl,ls1043a-pcie" > "fsl,ls1012a-pcie" > EP mode: > - "fsl,ls1046a-pcie-ep", "fsl,ls-pcie-ep" > + "fsl,ls-pcie-ep" Wasn't this a fallback? Each line should be one valid combination of compatible strings. > + "fsl,ls1046a-pcie-ep" > + "fsl,ls1088a-pcie-ep" > + "fsl,ls2088a-pcie-ep" > - reg: base addresses and lengths of the PCIe controller register blocks. > - interrupts: A list of interrupt outputs of the controller. Must contain an > entry for each entry in the interrupt-names property. > -- > 2.9.5 >