From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v3 02/14] dt-bindings: display, renesas,du: Document cmms property Date: Wed, 28 Aug 2019 11:28:46 +0300 Message-ID: <20190828082846.GA27842@pendragon.ideasonboard.com> References: <20190825135154.11488-1-jacopo+renesas@jmondi.org> <20190825135154.11488-3-jacopo+renesas@jmondi.org> <20190827202945.GA3488@bogus> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Rob Herring , Jacopo Mondi , Kieran Bingham , Simon Horman , Ulrich Hecht , David Airlie , Daniel Vetter , Koji Matsuoka , muroya@ksk.co.jp, VenkataRajesh.Kalakodima@in.bosch.com, Harsha.ManjulaMallikarjun@in.bosch.com, Linux-Renesas , DRI Development , Linux Kernel Mailing List , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Mark Rutland List-Id: devicetree@vger.kernel.org On Wed, Aug 28, 2019 at 09:32:23AM +0200, Geert Uytterhoeven wrote: > On Tue, Aug 27, 2019 at 10:29 PM Rob Herring wrote: > > On Sun, Aug 25, 2019 at 03:51:42PM +0200, Jacopo Mondi wrote: > > > Document the newly added 'cmms' property which accepts a list of phandle > > > and channel index pairs that point to the CMM units available for each > > > Display Unit output video channel. > > > > > > Signed-off-by: Jacopo Mondi > > > Reviewed-by: Laurent Pinchart > > > --- > > > Documentation/devicetree/bindings/display/renesas,du.txt | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt b/Documentation/devicetree/bindings/display/renesas,du.txt > > > index c97dfacad281..c2265e2a1af2 100644 > > > --- a/Documentation/devicetree/bindings/display/renesas,du.txt > > > +++ b/Documentation/devicetree/bindings/display/renesas,du.txt > > > @@ -45,6 +45,10 @@ Required Properties: > > > instance that serves the DU channel, and the channel index identifies the > > > LIF instance in that VSP. > > > > > > + - cmms: A list of phandles to the CMM instances present in the SoC, one > > > + for each available DU channel. The property shall not be specified for > > > + SoCs that do not provide any CMM (such as V3M and V3H). > > > > renesas,cmms > > So I guess we really wanted to have the prefix for the vsps property, too? Yes, we should have :-( My bad. -- Regards, Laurent Pinchart