From: Tony Lindgren <tony@atomide.com>
To: linux-omap@vger.kernel.org
Cc: "Benoît Cousson" <bcousson@baylibre.com>,
devicetree@vger.kernel.org, "Jacopo Mondi" <jacopo@jmondi.org>,
"Marcel Partap" <mpartap@gmx.net>,
"Merlijn Wajer" <merlijn@wizzup.org>,
"Michael Scott" <hashcode0f@gmail.com>,
NeKit <nekit1000@gmail.com>, "Pavel Machek" <pavel@ucw.cz>,
"Sebastian Reichel" <sre@kernel.org>
Subject: Re: [PATCH] ARM: dts: omap4-droid4: Allow 350mA current for USB peripherals
Date: Wed, 28 Aug 2019 08:34:48 -0700 [thread overview]
Message-ID: <20190828153448.GC52127@atomide.com> (raw)
In-Reply-To: <20190828151706.32643-1-tony@atomide.com>
* Tony Lindgren <tony@atomide.com> [190828 08:17]:
> Looks like we can use some USB Ethernet dongles for example if we increase
> the allowed power limit.
>
> A similar PMIC MC13783 documents maximum current limit as 350 mA in in
> "Table 10-3. VUSB Regulator Main Characteristics". Since we have no
> other documentation, let's use that value as the limit.
Oops, that's too much, it's not VUSB regulator but VBUS regulator
that lists 300 mA max instead of 350 mA for VUSB regulator.
Updated patch below.
Regards,
Tony
8< ------------------------
>From tony Mon Sep 17 00:00:00 2001
From: Tony Lindgren <tony@atomide.com>
Date: Wed, 28 Aug 2019 08:11:26 -0700
Subject: [PATCH] ARM: dts: omap4-droid4: Allow 300mA current for USB
peripherals
Looks like we can use some USB Ethernet dongles for example if we increase
the allowed power limit.
A similar PMIC MC13783 documents maximum current limit as 300 mA in in
"Table 10-4. VBUS Regulator Main Characteristics". Since we have no
other documentation, let's use that value as the limit.
Cc: Jacopo Mondi <jacopo@jmondi.org>
Cc: Marcel Partap <mpartap@gmx.net>
Cc: Merlijn Wajer <merlijn@wizzup.org>
Cc: Michael Scott <hashcode0f@gmail.com>
Cc: NeKit <nekit1000@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Sebastian Reichel <sre@kernel.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
arch/arm/boot/dts/omap4-droid4-xt894.dts | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/omap4-droid4-xt894.dts b/arch/arm/boot/dts/omap4-droid4-xt894.dts
--- a/arch/arm/boot/dts/omap4-droid4-xt894.dts
+++ b/arch/arm/boot/dts/omap4-droid4-xt894.dts
@@ -781,7 +781,12 @@
&usb_otg_hs {
interface-type = <1>;
mode = <3>;
- power = <50>;
+
+ /*
+ * Max 300 mA steps based on similar PMIC MC13783UG.pdf "Table 10-4.
+ * VBUS Regulator Main Characteristics". Binding uses 2 mA units.
+ */
+ power = <150>;
};
&i2c4 {
--
2.23.0
prev parent reply other threads:[~2019-08-28 15:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 15:17 [PATCH] ARM: dts: omap4-droid4: Allow 350mA current for USB peripherals Tony Lindgren
2019-08-28 15:34 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190828153448.GC52127@atomide.com \
--to=tony@atomide.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=hashcode0f@gmail.com \
--cc=jacopo@jmondi.org \
--cc=linux-omap@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=mpartap@gmx.net \
--cc=nekit1000@gmail.com \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).