From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v3 01/10] software node: Get reference to parent swnode in get_parent op Date: Fri, 30 Aug 2019 15:33:07 +0300 Message-ID: <20190830123307.GA2680@smile.fi.intel.com> References: <20190829101043.24963-1-sakari.ailus@linux.intel.com> <20190829101043.24963-2-sakari.ailus@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190829101043.24963-2-sakari.ailus@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Sakari Ailus Cc: Petr Mladek , linux-kernel@vger.kernel.org, rafael@kernel.org, linux-acpi@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring List-Id: devicetree@vger.kernel.org On Thu, Aug 29, 2019 at 01:10:34PM +0300, Sakari Ailus wrote: > The software_node_get_parent() returned a pointer to the parent swnode, > but did not take a reference to it, leading the caller to put a reference > that was not taken. Take that reference now. > > Fixes: 59abd83672f7 ("drivers: base: Introducing software nodes to the > firmware node framework") Reviewed-by: Andy Shevchenko > Signed-off-by: Sakari Ailus > --- > drivers/base/swnode.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c > index e7b3aa3bd55ad..a7cb41812cfda 100644 > --- a/drivers/base/swnode.c > +++ b/drivers/base/swnode.c > @@ -520,7 +520,10 @@ software_node_get_parent(const struct fwnode_handle *fwnode) > { > struct swnode *swnode = to_swnode(fwnode); > > - return swnode ? (swnode->parent ? &swnode->parent->fwnode : NULL) : NULL; > + if (!swnode || !swnode->parent) > + return NULL; > + > + return fwnode_handle_get(&swnode->parent->fwnode); > } > > static struct fwnode_handle * > -- > 2.20.1 > -- With Best Regards, Andy Shevchenko