From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sakari Ailus Subject: Re: [V2, 2/2] media: i2c: Add DW9768 VCM driver Date: Thu, 5 Sep 2019 13:40:01 +0300 Message-ID: <20190905104001.GZ5475@paasikivi.fi.intel.com> References: <20190905072142.14606-1-dongchun.zhu@mediatek.com> <20190905072142.14606-3-dongchun.zhu@mediatek.com> <20190905082134.GY5475@paasikivi.fi.intel.com> <20190905101908.GB2680@smile.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <20190905101908.GB2680@smile.fi.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Andy Shevchenko Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, drinkcat@chromium.org, srv_heupstream@mediatek.com, sam.hung@mediatek.com, shengnan.wang@mediatek.com, Javier Martinez Canillas , tfiga@chromium.org, sj.huang@mediatek.com, robh+dt@kernel.org, linux-mediatek@lists.infradead.org, dongchun.zhu@mediatek.com, matthias.bgg@gmail.com, bingbu.cao@intel.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org List-Id: devicetree@vger.kernel.org On Thu, Sep 05, 2019 at 01:19:08PM +0300, Andy Shevchenko wrote: > On Thu, Sep 05, 2019 at 11:21:34AM +0300, Sakari Ailus wrote: > > On Thu, Sep 05, 2019 at 03:21:42PM +0800, dongchun.zhu@mediatek.com wro= te: > > > From: Dongchun Zhu > = > > > +static const struct i2c_device_id dw9768_id_table[] =3D { > > > + { DW9768_NAME, 0 }, > > > + { }, > > = > > Could you drop the I=B2C ID table? > = > But why? > It will allow you to instanciate the device from user space. The device is supposed to be present in DT (or ACPI tables) already. > = > +Cc: Javier. > = > Javier, is it needed in new code? -- = Sakari Ailus sakari.ailus@linux.intel.com