From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sakari Ailus Subject: Re: [V3, 2/2] media: i2c: Add Omnivision OV02A10 camera sensor driver Date: Thu, 5 Sep 2019 13:45:46 +0300 Message-ID: <20190905104546.GA5475@paasikivi.fi.intel.com> References: <20190819034331.13098-1-dongchun.zhu@mediatek.com> <20190819034331.13098-3-dongchun.zhu@mediatek.com> <20190819083009.GC6133@paasikivi.fi.intel.com> <1567676465.21623.100.camel@mhfsdcap03> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1567676465.21623.100.camel@mhfsdcap03> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Dongchun Zhu Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, drinkcat@chromium.org, srv_heupstream@mediatek.com, shengnan.wang@mediatek.com, tfiga@chromium.org, louis.kuo@mediatek.com, sj.huang@mediatek.com, robh+dt@kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, bingbu.cao@intel.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org List-Id: devicetree@vger.kernel.org Hi Dongchun, On Thu, Sep 05, 2019 at 05:41:05PM +0800, Dongchun Zhu wrote: ... > > > + ret = regulator_bulk_enable(OV02A10_NUM_SUPPLIES, ov02a10->supplies); > > > + if (ret < 0) { > > > + dev_err(dev, "Failed to enable regulators\n"); > > > + goto disable_clk; > > > + } > > > + msleep_range(7); > > > > This has some potential of clashing with more generic functions in the > > future. Please use usleep_range directly, or msleep. > > > > Did you mean using usleep_range(7*1000, 8*1000), as used in patch v1? > https://patchwork.kernel.org/patch/10957225/ Yes, please. -- Sakari Ailus sakari.ailus@linux.intel.com