From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sakari Ailus Subject: Re: [V2, 1/2] media: i2c: dw9768: Add DT support and MAINTAINERS entry Date: Thu, 5 Sep 2019 15:00:12 +0300 Message-ID: <20190905120012.GD5475@paasikivi.fi.intel.com> References: <20190905072142.14606-1-dongchun.zhu@mediatek.com> <20190905072142.14606-2-dongchun.zhu@mediatek.com> <20190905101406.GA2680@smile.fi.intel.com> <20190905104829.GB5475@paasikivi.fi.intel.com> <20190905113509.GD2680@smile.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Javier Martinez Canillas Cc: Mark Rutland , devicetree@vger.kernel.org, drinkcat@chromium.org, srv_heupstream@mediatek.com, sam.hung@mediatek.com, shengnan.wang@mediatek.com, Andy Shevchenko , Tomasz Figa , sj.huang@mediatek.com, Rob Herring , linux-mediatek@lists.infradead.org, dongchun.zhu@mediatek.com, Matthias Brugger , bingbu.cao@intel.com, Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, Linux Media Mailing List List-Id: devicetree@vger.kernel.org On Thu, Sep 05, 2019 at 01:49:28PM +0200, Javier Martinez Canillas wrote: > On Thu, Sep 5, 2019 at 1:35 PM Andy Shevchenko > wrote: > > > > On Thu, Sep 05, 2019 at 01:48:30PM +0300, Sakari Ailus wrote: > > > On Thu, Sep 05, 2019 at 01:14:06PM +0300, Andy Shevchenko wrote: > > > > On Thu, Sep 05, 2019 at 03:21:41PM +0800, dongchun.zhu@mediatek.com wrote: > > > > > From: Dongchun Zhu > > > > > > > > > > This patch is to add the Devicetree binding documentation and > > > > > MAINTAINERS entry for dw9768 actuator. > > > > > > > > > > Signed-off-by: Dongchun Zhu > > > > > --- > > > > > Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.txt | 9 +++++++++ > > > > > MAINTAINERS | 7 +++++++ > > > > > > > > This should be: > > > > 1) two separate patches > > > > > > Why? The MAINTAINERS entry is usually added in the first patch needing it, > > > isn't it? > > > > Bindings are required to be a separate patch. > > Rob, is it still the case or am I mistaken? > > > > According to the rule 0 in [1] it should be a separate patch indeed > and also use as subject "dt-bindings: : ..." which this > patch also doesn't follow. > So if I'm reading that document correctly, then I think the > maintainers entry should be added in patch 2/2 along with the driver. I understand [1] discussing the need for the bindings to be a "separate patch" means a separate patch from the _driver_ for the device, not the MAINTAINERS change. Bindings come before the driver, and MAINTAINERS entry needs to be there no later than the files. And I see no reason to add a separate patch just for MAINTAINERS change. > > [1]: https://www.kernel.org/doc/Documentation/devicetree/bindings/submitting-patches.txt -- Sakari Ailus sakari.ailus@linux.intel.com