From: Mark Brown <broonie@kernel.org>
To: Philippe Schenker <philippe.schenker@toradex.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Liam Girdwood <lgirdwood@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Max Krummenacher <max.krummenacher@toradex.com>,
Rob Herring <robh+dt@kernel.org>,
Stefan Agner <stefan.agner@toradex.com>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Mark Rutland <mark.rutland@arm.com>,
Luka Pivk <luka.pivk@toradex.com>
Subject: Re: [PATCH 1/3] regulator: fixed: add possibility to enable by clock
Date: Thu, 5 Sep 2019 19:06:15 +0100 [thread overview]
Message-ID: <20190905180615.GG4053@sirena.co.uk> (raw)
In-Reply-To: <20190903080336.32288-2-philippe.schenker@toradex.com>
[-- Attachment #1: Type: text/plain, Size: 768 bytes --]
On Tue, Sep 03, 2019 at 08:03:46AM +0000, Philippe Schenker wrote:
> This commit adds the possibility to choose the compatible
> "regulator-fixed-clock" in devicetree.
>
> This is a special regulator-fixed that has to have a clock, from which
> the regulator gets switched on and off.
This seems conceptually fine. Minor issues though:
> +static int reg_clock_is_enabled(struct regulator_dev *rdev)
> +{
> + struct fixed_voltage_data *priv = rdev_get_drvdata(rdev);
> +
> + if (priv->clk_enable_counter > 0)
> + return 1;
> +
> + return 0;
> +}
This could just be return priv->clk_enable_counter > 0 - ideally the
clock API would let us query if the clock is enabled but that might be a
bit confused anyway given that it's possibly shared.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-09-05 18:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 8:03 [PATCH 0/3] Add new binding regulator-fixed-clock to regulator-fixed Philippe Schenker
2019-09-03 8:03 ` [PATCH 1/3] regulator: fixed: add possibility to enable by clock Philippe Schenker
2019-09-05 18:06 ` Mark Brown [this message]
2019-09-10 6:08 ` Philippe Schenker
2019-09-10 6:14 ` Philippe Schenker
2019-09-03 8:03 ` [PATCH 2/3] ARM: dts: imx6ull-colibri: add phy-supply and respective regulator Philippe Schenker
2019-09-03 8:03 ` [PATCH 3/3] dt-bindings: regulator: add regulator-fixed-clock binding Philippe Schenker
2019-09-03 8:45 ` Rob Herring
2019-09-04 8:07 ` Philippe Schenker
2019-09-04 9:06 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190905180615.GG4053@sirena.co.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luka.pivk@toradex.com \
--cc=marcel.ziswiler@toradex.com \
--cc=mark.rutland@arm.com \
--cc=max.krummenacher@toradex.com \
--cc=philippe.schenker@toradex.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefan.agner@toradex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox