From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH 1/2] net: phy: dp83867: Add documentation for SGMII mode type Date: Sun, 8 Sep 2019 10:54:17 +0200 Message-ID: <20190908085417.GA28580@lunn.ch> References: <20190907153919.GC21922@lunn.ch> <1567700761-14195-1-git-send-email-vitaly.gaiduk@cloudbear.ru> <1567700761-14195-2-git-send-email-vitaly.gaiduk@cloudbear.ru> <2894361567896439@iva5-be053096037b.qloud-c.yandex.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <2894361567896439@iva5-be053096037b.qloud-c.yandex.net> Sender: linux-kernel-owner@vger.kernel.org To: Vitaly Gaiduk Cc: "davem@davemloft.net" , "robh+dt@kernel.org" , "f.fainelli@gmail.com" , Mark Rutland , "netdev@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Trent Piepho List-Id: devicetree@vger.kernel.org On Sun, Sep 08, 2019 at 01:47:19AM +0300, Vitaly Gaiduk wrote: > Hi, Andrew.
I=E2=80=99m ready to do this property with such name but = is it good practice to do such long names? :)
Also, Trent Piepho = wrote about sgmii-clk and merged all ideas we have =E2=80=9Cti,sgmii-ref-cl= k=E2=80=9D.
It=E2=80=99s better, isn=E2=80=99t it?
Vita= ly.

07.09.2019, 18:39, "Andrew Lunn" <andrew@lunn.c= h>:

On Thu, Sep 05, 2019 at 07:26:00PM +0300, Vitaly= Gaiduk wrote:

=C2=A0Add documentation of ti,sgmii-type which can be used to = select
=C2=A0SGMII mode type (4 or 6-wire).

=C2=A0Signed-of= f-by: Vitaly Gaiduk <vital= y.gaiduk@cloudbear.ru>
=C2=A0---
=C2=A0=C2=A0Documentation= /devicetree/bindings/net/ti,dp83867.txt | 1 +
=C2=A0=C2=A01 file chang= ed, 1 insertion(+)

=C2=A0diff --git a/Documentation/devicetree/b= indings/net/ti,dp83867.txt b/Documentation/devicetree/bindings/net/ti,dp838= 67.txt
=C2=A0index db6aa3f2215b..18e7fd52897f 100644
=C2=A0--- a/= Documentation/devicetree/bindings/net/ti,dp83867.txt
=C2=A0+++ b/Docum= entation/devicetree/bindings/net/ti,dp83867.txt
=C2=A0@@ -37,6 +37,7 @= @ Optional property:
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0for ap= plicable values. The CLK_OUT pin can also
=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0be disabled by this property. When omitted, the
=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0PHY's default will be left as is.
= =C2=A0+ - ti,sgmii-type - This denotes the fact which SGMII mode is used (4= or 6-wire).


Hi Vitaly

You probably w= ant to make this a Boolean. I don't think SGMII type is
a good idea. T= his is about enabling the receive clock to be passed to
the MAC. So ho= w about ti,sgmii-ref-clock-output-enable.

=C2=A0=C2=A0=C2=A0=C2= =A0Andrew

Hi Vitaly Please reconfigure your mail client to not obfuscate with HTML. The length should be O.K. For a PHY node, it should not be too deeply indented, unless it happens to be part of an Ethernet switch. Andrew