From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v6 01/12] tools lib traceevent: Convert remaining %p[fF] users to %p[sS] Date: Tue, 10 Sep 2019 12:22:33 +0300 Message-ID: <20190910092233.GY2680@smile.fi.intel.com> References: <20190910084707.18380-1-sakari.ailus@linux.intel.com> <20190910084707.18380-2-sakari.ailus@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190910084707.18380-2-sakari.ailus@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Sakari Ailus Cc: Petr Mladek , linux-kernel@vger.kernel.org, rafael@kernel.org, linux-acpi@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Heikki Krogerus , Joe Perches , Steven Rostedt , Arnaldo Carvalho de Melo , Tzvetomir Stoyanov , linux-trace-devel@vger.kernel.org, Jiri Olsa , Namhyung Kim List-Id: devicetree@vger.kernel.org On Tue, Sep 10, 2019 at 11:46:56AM +0300, Sakari Ailus wrote: > There are no in-kernel %p[fF] users left. Convert the traceevent tool, > too, to align with the kernel. > function. The _tep_ argument is the trace event parser context. The _name_ is > -the name of the function, the string is copied internally. The _addr_ is > -the start address of the function. The _mod_ is the kernel module > -the function may be in (NULL for none). > +the name of the function, the string is copied internally. The _addr_ is the > +start address of the function. The _mod_ is the kernel module the function may > +be in (NULL for none). This seems a churn of reformatting. > - if (asprintf(&format, "%%pf: (NO FORMAT FOUND at %llx)\n", addr) < 0) > + if (asprintf(&format, "%%ps: (NO FORMAT FOUND at %llx)\n", > + addr) < 0) Splitting line also seems a churn to me. But this one is up to maintainers. Other than above, looks good to me, thanks! -- With Best Regards, Andy Shevchenko