From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andriy Shevchenko Subject: Re: [PATCH v1 0/2] pinctrl: Add new pinctrl/GPIO driver Date: Thu, 12 Sep 2019 16:58:06 +0300 Message-ID: <20190912135806.GA2680@smile.fi.intel.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Linus Walleij Cc: Rahul Tanwar , Mika Westerberg , Rob Herring , Mark Rutland , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Rob Herring , qi-ming.wu@intel.com, yixin.zhu@linux.intel.com, cheol.yong.kim@intel.com, Mathias Nyman , Heikki Krogerus List-Id: devicetree@vger.kernel.org On Thu, Sep 12, 2019 at 11:11:32AM +0100, Linus Walleij wrote: > Hi Rahul, > > thanks for your patches! > > On Thu, Sep 12, 2019 at 8:59 AM Rahul Tanwar > wrote: > > > This series is to add pinctrl & GPIO controller driver for a new SoC. > > Patch 1 adds pinmux & GPIO controller driver. > > Patch 2 adds the dt bindings document & include file. > > > > Patches are against Linux 5.3-rc5 at below Git tree: > > git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git > > OK nice, I think you need to include Mika Westerberg on this review > as well, because I think he likes to stay on top of all things intel > in pin control. (Also included two other Intel folks in Finland who usually > take an interest in these things.) Linus, nevertheless I guess you may give your comments WRT device tree use (bindings, helpers, etc) along with some basics, (like devm_*() [ab]use I just noticed). -- With Best Regards, Andy Shevchenko