From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH v1 0/2] pinctrl: Add new pinctrl/GPIO driver Date: Fri, 13 Sep 2019 11:18:07 +0300 Message-ID: <20190913081807.GB27291@lahna.fi.intel.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Linus Walleij Cc: Rahul Tanwar , Rob Herring , Mark Rutland , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Rob Herring , Andriy Shevchenko , qi-ming.wu@intel.com, yixin.zhu@linux.intel.com, cheol.yong.kim@intel.com, Mathias Nyman , Heikki Krogerus List-Id: devicetree@vger.kernel.org On Thu, Sep 12, 2019 at 11:11:32AM +0100, Linus Walleij wrote: > Hi Rahul, > > thanks for your patches! > > On Thu, Sep 12, 2019 at 8:59 AM Rahul Tanwar > wrote: > > > This series is to add pinctrl & GPIO controller driver for a new SoC. > > Patch 1 adds pinmux & GPIO controller driver. > > Patch 2 adds the dt bindings document & include file. > > > > Patches are against Linux 5.3-rc5 at below Git tree: > > git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git > > OK nice, I think you need to include Mika Westerberg on this review > as well, because I think he likes to stay on top of all things intel > in pin control. (Also included two other Intel folks in Finland who usually > take an interest in these things.) Thanks Linus for looping me in. Even if this is not directly based on the stuff we have under drivers/pinctrl/intel/*, I have a couple of comments. I don't have this patch series in my inbox so I'm commenting here. Since the driver name is equilibrium I suggest you to name intel_pinctrl_driver and the like (probe, remove) to follow that convention to avoid confusing this with the Intel pinctrl drivers under drivers/pinctrl/intel/*. Maybe use eqbr prefix so then intel_pinctrl_driver becomes eqbr_pinctrl_driver and so on. Also all the structures like intel_pinctrl_drv_data should be changed accordingly. Ditto for: MODULE_DESCRIPTION("Intel Pinctrl Driver for LGM SoC"); I think better would be: MODULE_DESCRIPTION("Pinctrl Driver for LGM SoC (Equilibrium)"); Anyway you get the idea :)