From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux admin Subject: Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed Date: Tue, 17 Sep 2019 18:37:28 +0100 Message-ID: <20190917173728.GZ25745@shell.armlinux.org.uk> References: <20190917124101.GA1200564@arch-dsk-01> <20190917125434.GH20778@lunn.ch> <20190917133253.GA1210141@arch-dsk-01> <20190917133942.GR25745@shell.armlinux.org.uk> <20190917151707.GV25745@shell.armlinux.org.uk> <20190917153027.GW25745@shell.armlinux.org.uk> <20190917163427.GA1475935@arch-dsk-01> <20190917170419.GX25745@shell.armlinux.org.uk> <20190917171913.GY25745@shell.armlinux.org.uk> <20190917172658.GB9591@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190917172658.GB9591@lunn.ch> Sender: linux-kernel-owner@vger.kernel.org To: Andrew Lunn Cc: tinywrkb , Mark Rutland , Baruch Siach , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Shawn Guo , Sascha Hauer , open list , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Tue, Sep 17, 2019 at 07:26:58PM +0200, Andrew Lunn wrote: > > diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c > > index b3893347804d..85cf4a4a5e81 100644 > > --- a/drivers/net/phy/at803x.c > > +++ b/drivers/net/phy/at803x.c > > Hi Russell > > This won't work. In the kernel logs, you see > > kernel: Generic PHY 2188000.ethernet-1:00: attached PHY driver [Generic PHY] > > The generic PHY driver is being used, not the at803x driver. Well, the _correct_ driver needs to be used for the PHY specific features to be properly controlled. Using the generic driver in this situation will not be guaranteed to work. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up