* [PATCH v4 1/9] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation [not found] <20190906135436.10622-1-jacopo+renesas@jmondi.org> @ 2019-09-06 13:54 ` Jacopo Mondi 2019-09-11 19:04 ` Kieran Bingham ` (2 more replies) 2019-09-06 13:54 ` [PATCH v4 2/9] dt-bindings: display, renesas,du: Document cmms property Jacopo Mondi 1 sibling, 3 replies; 9+ messages in thread From: Jacopo Mondi @ 2019-09-06 13:54 UTC (permalink / raw) To: laurent.pinchart, kieran.bingham+renesas, geert, horms, uli+renesas, VenkataRajesh.Kalakodima Cc: Jacopo Mondi, airlied, daniel, koji.matsuoka.xm, muroya, Harsha.ManjulaMallikarjun, linux-renesas-soc, dri-devel, linux-kernel, devicetree, robh+dt, mark.rutland Add device tree bindings documentation for the Renesas R-Car Display Unit Color Management Module. CMM is the image enhancement module available on each R-Car DU video channel on R-Car Gen2 and Gen3 SoCs (V3H and V3M excluded). Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> --- .../bindings/display/renesas,cmm.yaml | 64 +++++++++++++++++++ 1 file changed, 64 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/renesas,cmm.yaml diff --git a/Documentation/devicetree/bindings/display/renesas,cmm.yaml b/Documentation/devicetree/bindings/display/renesas,cmm.yaml new file mode 100644 index 000000000000..9e5922689cd7 --- /dev/null +++ b/Documentation/devicetree/bindings/display/renesas,cmm.yaml @@ -0,0 +1,64 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/renesas,cmm.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Renesas R-Car Color Management Module (CMM) + +maintainers: + - Laurent Pinchart <laurent.pinchart@ideasonboard.com> + - Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> + - Jacopo Mondi <jacopo+renesas@jmondi.org> + +description: |+ + Renesas R-Car color management module connected to R-Car DU video channels. + It provides image enhancement functions such as 1-D look-up tables (LUT), + 3-D look-up tables (CMU), 1D-histogram generation (HGO), and color + space conversion (CSC). + +properties: + compatible: + items: + - enum: + - renesas,r8a7795-cmm + - renesas,r8a7796-cmm + - renesas,r8a77965-cmm + - renesas,r8a77990-cmm + - renesas,r8a77995-cmm + - enum: + - renesas,rcar-gen3-cmm + - renesas,rcar-gen2-cmm + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + resets: + maxItems: 1 + + power-domains: + maxItems: 1 + +required: + - compatible + - reg + - clocks + - resets + - power-domains + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/r8a7796-cpg-mssr.h> + #include <dt-bindings/power/r8a7796-sysc.h> + + cmm0: cmm@fea40000 { + compatible = "renesas,r8a7796-cmm"; + reg = <0 0xfea40000 0 0x1000>; + power-domains = <&sysc R8A7796_PD_ALWAYS_ON>; + clocks = <&cpg CPG_MOD 711>; + resets = <&cpg 711>; + }; -- 2.23.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v4 1/9] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation 2019-09-06 13:54 ` [PATCH v4 1/9] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation Jacopo Mondi @ 2019-09-11 19:04 ` Kieran Bingham 2019-09-17 17:55 ` Rob Herring 2019-09-18 22:08 ` Laurent Pinchart 2 siblings, 0 replies; 9+ messages in thread From: Kieran Bingham @ 2019-09-11 19:04 UTC (permalink / raw) To: Jacopo Mondi, laurent.pinchart, geert, horms, uli+renesas, VenkataRajesh.Kalakodima Cc: airlied, daniel, koji.matsuoka.xm, muroya, Harsha.ManjulaMallikarjun, linux-renesas-soc, dri-devel, linux-kernel, devicetree, robh+dt, mark.rutland Hi Jacopo, On 06/09/2019 14:54, Jacopo Mondi wrote: > Add device tree bindings documentation for the Renesas R-Car Display > Unit Color Management Module. > > CMM is the image enhancement module available on each R-Car DU video > channel on R-Car Gen2 and Gen3 SoCs (V3H and V3M excluded). > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > --- > .../bindings/display/renesas,cmm.yaml | 64 +++++++++++++++++++ > 1 file changed, 64 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/renesas,cmm.yaml > > diff --git a/Documentation/devicetree/bindings/display/renesas,cmm.yaml b/Documentation/devicetree/bindings/display/renesas,cmm.yaml > new file mode 100644 > index 000000000000..9e5922689cd7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/renesas,cmm.yaml > @@ -0,0 +1,64 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/renesas,cmm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas R-Car Color Management Module (CMM) > + > +maintainers: > + - Laurent Pinchart <laurent.pinchart@ideasonboard.com> > + - Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > + - Jacopo Mondi <jacopo+renesas@jmondi.org> > + > +description: |+ > + Renesas R-Car color management module connected to R-Car DU video channels. > + It provides image enhancement functions such as 1-D look-up tables (LUT), > + 3-D look-up tables (CMU), 1D-histogram generation (HGO), and color s/CMU/CLU/ > + space conversion (CSC). > + > +properties: > + compatible: > + items: > + - enum: > + - renesas,r8a7795-cmm > + - renesas,r8a7796-cmm > + - renesas,r8a77965-cmm > + - renesas,r8a77990-cmm > + - renesas,r8a77995-cmm > + - enum: > + - renesas,rcar-gen3-cmm > + - renesas,rcar-gen2-cmm > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - clocks > + - resets > + - power-domains > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/r8a7796-cpg-mssr.h> > + #include <dt-bindings/power/r8a7796-sysc.h> > + > + cmm0: cmm@fea40000 { > + compatible = "renesas,r8a7796-cmm"; > + reg = <0 0xfea40000 0 0x1000>; > + power-domains = <&sysc R8A7796_PD_ALWAYS_ON>; > + clocks = <&cpg CPG_MOD 711>; > + resets = <&cpg 711>; > + }; > -- > 2.23.0 > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 1/9] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation 2019-09-06 13:54 ` [PATCH v4 1/9] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation Jacopo Mondi 2019-09-11 19:04 ` Kieran Bingham @ 2019-09-17 17:55 ` Rob Herring 2019-09-18 22:08 ` Laurent Pinchart 2 siblings, 0 replies; 9+ messages in thread From: Rob Herring @ 2019-09-17 17:55 UTC (permalink / raw) To: Jacopo Mondi Cc: laurent.pinchart, kieran.bingham+renesas, geert, horms, uli+renesas, VenkataRajesh.Kalakodima, airlied, daniel, koji.matsuoka.xm, muroya, Harsha.ManjulaMallikarjun, linux-renesas-soc, dri-devel, linux-kernel, devicetree, mark.rutland On Fri, Sep 06, 2019 at 03:54:28PM +0200, Jacopo Mondi wrote: > Add device tree bindings documentation for the Renesas R-Car Display > Unit Color Management Module. > > CMM is the image enhancement module available on each R-Car DU video > channel on R-Car Gen2 and Gen3 SoCs (V3H and V3M excluded). > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > --- > .../bindings/display/renesas,cmm.yaml | 64 +++++++++++++++++++ > 1 file changed, 64 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/renesas,cmm.yaml > > diff --git a/Documentation/devicetree/bindings/display/renesas,cmm.yaml b/Documentation/devicetree/bindings/display/renesas,cmm.yaml > new file mode 100644 > index 000000000000..9e5922689cd7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/renesas,cmm.yaml > @@ -0,0 +1,64 @@ > +# SPDX-License-Identifier: GPL-2.0 For new bindings: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/renesas,cmm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas R-Car Color Management Module (CMM) > + > +maintainers: > + - Laurent Pinchart <laurent.pinchart@ideasonboard.com> > + - Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > + - Jacopo Mondi <jacopo+renesas@jmondi.org> > + > +description: |+ > + Renesas R-Car color management module connected to R-Car DU video channels. > + It provides image enhancement functions such as 1-D look-up tables (LUT), > + 3-D look-up tables (CMU), 1D-histogram generation (HGO), and color > + space conversion (CSC). > + > +properties: > + compatible: > + items: > + - enum: > + - renesas,r8a7795-cmm > + - renesas,r8a7796-cmm > + - renesas,r8a77965-cmm > + - renesas,r8a77990-cmm > + - renesas,r8a77995-cmm > + - enum: > + - renesas,rcar-gen3-cmm > + - renesas,rcar-gen2-cmm This allows 10 valid cases when I imagine there's only really 5. I'm okay leaving it, but might be better to split into 2 under a 'oneOf'. I imagine there will be a lot of these for Renesas, so just be consistent. > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - clocks > + - resets > + - power-domains > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/r8a7796-cpg-mssr.h> > + #include <dt-bindings/power/r8a7796-sysc.h> > + > + cmm0: cmm@fea40000 { > + compatible = "renesas,r8a7796-cmm"; > + reg = <0 0xfea40000 0 0x1000>; > + power-domains = <&sysc R8A7796_PD_ALWAYS_ON>; > + clocks = <&cpg CPG_MOD 711>; > + resets = <&cpg 711>; > + }; > -- > 2.23.0 > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 1/9] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation 2019-09-06 13:54 ` [PATCH v4 1/9] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation Jacopo Mondi 2019-09-11 19:04 ` Kieran Bingham 2019-09-17 17:55 ` Rob Herring @ 2019-09-18 22:08 ` Laurent Pinchart 2 siblings, 0 replies; 9+ messages in thread From: Laurent Pinchart @ 2019-09-18 22:08 UTC (permalink / raw) To: Jacopo Mondi Cc: kieran.bingham+renesas, geert, horms, uli+renesas, VenkataRajesh.Kalakodima, airlied, daniel, koji.matsuoka.xm, muroya, Harsha.ManjulaMallikarjun, linux-renesas-soc, dri-devel, linux-kernel, devicetree, robh+dt, mark.rutland Hi Jacopo, Thank you for the patch. On Fri, Sep 06, 2019 at 03:54:28PM +0200, Jacopo Mondi wrote: > Add device tree bindings documentation for the Renesas R-Car Display > Unit Color Management Module. > > CMM is the image enhancement module available on each R-Car DU video > channel on R-Car Gen2 and Gen3 SoCs (V3H and V3M excluded). > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> With the small issues pointed out by Kieran and Rob fixed, Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > .../bindings/display/renesas,cmm.yaml | 64 +++++++++++++++++++ > 1 file changed, 64 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/renesas,cmm.yaml > > diff --git a/Documentation/devicetree/bindings/display/renesas,cmm.yaml b/Documentation/devicetree/bindings/display/renesas,cmm.yaml > new file mode 100644 > index 000000000000..9e5922689cd7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/renesas,cmm.yaml > @@ -0,0 +1,64 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/renesas,cmm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas R-Car Color Management Module (CMM) > + > +maintainers: > + - Laurent Pinchart <laurent.pinchart@ideasonboard.com> > + - Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > + - Jacopo Mondi <jacopo+renesas@jmondi.org> > + > +description: |+ > + Renesas R-Car color management module connected to R-Car DU video channels. > + It provides image enhancement functions such as 1-D look-up tables (LUT), > + 3-D look-up tables (CMU), 1D-histogram generation (HGO), and color > + space conversion (CSC). > + > +properties: > + compatible: > + items: > + - enum: > + - renesas,r8a7795-cmm > + - renesas,r8a7796-cmm > + - renesas,r8a77965-cmm > + - renesas,r8a77990-cmm > + - renesas,r8a77995-cmm > + - enum: > + - renesas,rcar-gen3-cmm > + - renesas,rcar-gen2-cmm > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - clocks > + - resets > + - power-domains > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/r8a7796-cpg-mssr.h> > + #include <dt-bindings/power/r8a7796-sysc.h> > + > + cmm0: cmm@fea40000 { > + compatible = "renesas,r8a7796-cmm"; > + reg = <0 0xfea40000 0 0x1000>; > + power-domains = <&sysc R8A7796_PD_ALWAYS_ON>; > + clocks = <&cpg CPG_MOD 711>; > + resets = <&cpg 711>; > + }; -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v4 2/9] dt-bindings: display, renesas,du: Document cmms property [not found] <20190906135436.10622-1-jacopo+renesas@jmondi.org> 2019-09-06 13:54 ` [PATCH v4 1/9] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation Jacopo Mondi @ 2019-09-06 13:54 ` Jacopo Mondi 2019-09-11 16:06 ` Kieran Bingham 1 sibling, 1 reply; 9+ messages in thread From: Jacopo Mondi @ 2019-09-06 13:54 UTC (permalink / raw) To: laurent.pinchart, kieran.bingham+renesas, geert, horms, uli+renesas, VenkataRajesh.Kalakodima Cc: Jacopo Mondi, airlied, daniel, koji.matsuoka.xm, muroya, Harsha.ManjulaMallikarjun, linux-renesas-soc, dri-devel, linux-kernel, devicetree, robh+dt, mark.rutland Document the newly added 'cmms' property which accepts a list of phandle and channel index pairs that point to the CMM units available for each Display Unit output video channel. Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- Documentation/devicetree/bindings/display/renesas,du.txt | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt b/Documentation/devicetree/bindings/display/renesas,du.txt index c97dfacad281..1773b0a2f54f 100644 --- a/Documentation/devicetree/bindings/display/renesas,du.txt +++ b/Documentation/devicetree/bindings/display/renesas,du.txt @@ -45,6 +45,10 @@ Required Properties: instance that serves the DU channel, and the channel index identifies the LIF instance in that VSP. + - renesas,cmms: A list of phandles to the CMM instances present in the SoC, + one for each available DU channel. The property shall not be specified for + SoCs that do not provide any CMM (such as V3M and V3H). + Required nodes: The connections to the DU output video ports are modeled using the OF graph @@ -91,6 +95,7 @@ Example: R8A7795 (R-Car H3) ES2.0 DU <&cpg CPG_MOD 721>; clock-names = "du.0", "du.1", "du.2", "du.3"; vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>, <&vspd0 1>; + renesas,cmms = <&cmm0 &cmm1 &cmm2 &cmm3>; ports { #address-cells = <1>; -- 2.23.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v4 2/9] dt-bindings: display, renesas,du: Document cmms property 2019-09-06 13:54 ` [PATCH v4 2/9] dt-bindings: display, renesas,du: Document cmms property Jacopo Mondi @ 2019-09-11 16:06 ` Kieran Bingham 2019-09-17 17:58 ` Rob Herring 0 siblings, 1 reply; 9+ messages in thread From: Kieran Bingham @ 2019-09-11 16:06 UTC (permalink / raw) To: Jacopo Mondi, laurent.pinchart, geert, horms, uli+renesas, VenkataRajesh.Kalakodima Cc: airlied, daniel, koji.matsuoka.xm, muroya, Harsha.ManjulaMallikarjun, linux-renesas-soc, dri-devel, linux-kernel, devicetree, robh+dt, mark.rutland Hi Jacopo, On 06/09/2019 14:54, Jacopo Mondi wrote: > Document the newly added 'cmms' property which accepts a list of phandle > and channel index pairs that point to the CMM units available for each > Display Unit output video channel. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > Documentation/devicetree/bindings/display/renesas,du.txt | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt b/Documentation/devicetree/bindings/display/renesas,du.txt > index c97dfacad281..1773b0a2f54f 100644 > --- a/Documentation/devicetree/bindings/display/renesas,du.txt > +++ b/Documentation/devicetree/bindings/display/renesas,du.txt > @@ -45,6 +45,10 @@ Required Properties: > instance that serves the DU channel, and the channel index identifies the > LIF instance in that VSP. > > + - renesas,cmms: A list of phandles to the CMM instances present in the SoC, > + one for each available DU channel. The property shall not be specified for > + SoCs that do not provide any CMM (such as V3M and V3H). > + > Required nodes: > > The connections to the DU output video ports are modeled using the OF graph > @@ -91,6 +95,7 @@ Example: R8A7795 (R-Car H3) ES2.0 DU > <&cpg CPG_MOD 721>; > clock-names = "du.0", "du.1", "du.2", "du.3"; > vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>, <&vspd0 1>; > + renesas,cmms = <&cmm0 &cmm1 &cmm2 &cmm3>; Should these be comma separated in the same fashion as the vsps are separated? I don't really mind either way though ... Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > ports { > #address-cells = <1>; > -- > 2.23.0 > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 2/9] dt-bindings: display, renesas,du: Document cmms property 2019-09-11 16:06 ` Kieran Bingham @ 2019-09-17 17:58 ` Rob Herring 0 siblings, 0 replies; 9+ messages in thread From: Rob Herring @ 2019-09-17 17:58 UTC (permalink / raw) To: Kieran Bingham Cc: Jacopo Mondi, laurent.pinchart, geert, horms, uli+renesas, VenkataRajesh.Kalakodima, airlied, daniel, koji.matsuoka.xm, muroya, Harsha.ManjulaMallikarjun, linux-renesas-soc, dri-devel, linux-kernel, devicetree, mark.rutland On Wed, Sep 11, 2019 at 05:06:33PM +0100, Kieran Bingham wrote: > Hi Jacopo, > > On 06/09/2019 14:54, Jacopo Mondi wrote: > > Document the newly added 'cmms' property which accepts a list of phandle > > and channel index pairs that point to the CMM units available for each > > Display Unit output video channel. > > > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > --- > > Documentation/devicetree/bindings/display/renesas,du.txt | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt b/Documentation/devicetree/bindings/display/renesas,du.txt > > index c97dfacad281..1773b0a2f54f 100644 > > --- a/Documentation/devicetree/bindings/display/renesas,du.txt > > +++ b/Documentation/devicetree/bindings/display/renesas,du.txt > > @@ -45,6 +45,10 @@ Required Properties: > > instance that serves the DU channel, and the channel index identifies the > > LIF instance in that VSP. > > > > + - renesas,cmms: A list of phandles to the CMM instances present in the SoC, > > + one for each available DU channel. The property shall not be specified for > > + SoCs that do not provide any CMM (such as V3M and V3H). > > + > > Required nodes: > > > > The connections to the DU output video ports are modeled using the OF graph > > @@ -91,6 +95,7 @@ Example: R8A7795 (R-Car H3) ES2.0 DU > > <&cpg CPG_MOD 721>; > > clock-names = "du.0", "du.1", "du.2", "du.3"; > > vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>, <&vspd0 1>; > > + renesas,cmms = <&cmm0 &cmm1 &cmm2 &cmm3>; > > Should these be comma separated in the same fashion as the vsps are > separated? Yes. Doesn't matter from a dtb standpoint, but the schema are going to be stricter here. Bracket each unit. With that, Reviewed-by: Rob Herring <robh@kernel.org> > > I don't really mind either way though ... > > Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > > > > > ports { > > #address-cells = <1>; > > -- > > 2.23.0 > > > ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <20190906134341.9879-1-jacopo+renesas@jmondi.org>]
* [PATCH v4 1/9] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation [not found] <20190906134341.9879-1-jacopo+renesas@jmondi.org> @ 2019-09-06 13:43 ` Jacopo Mondi 2019-09-08 11:58 ` Simon Horman 0 siblings, 1 reply; 9+ messages in thread From: Jacopo Mondi @ 2019-09-06 13:43 UTC (permalink / raw) To: laurent.pinchart, kieran.bingham+renesas, geert, horms, uli, VenkataRajesh.Kalakodima Cc: Jacopo Mondi, devicetree, robh+dt, mark.rutland Add device tree bindings documentation for the Renesas R-Car Display Unit Color Management Module. CMM is the image enhancement module available on each R-Car DU video channel on R-Car Gen2 and Gen3 SoCs (V3H and V3M excluded). Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> --- .../bindings/display/renesas,cmm.yaml | 64 +++++++++++++++++++ 1 file changed, 64 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/renesas,cmm.yaml diff --git a/Documentation/devicetree/bindings/display/renesas,cmm.yaml b/Documentation/devicetree/bindings/display/renesas,cmm.yaml new file mode 100644 index 000000000000..9e5922689cd7 --- /dev/null +++ b/Documentation/devicetree/bindings/display/renesas,cmm.yaml @@ -0,0 +1,64 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/renesas,cmm.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Renesas R-Car Color Management Module (CMM) + +maintainers: + - Laurent Pinchart <laurent.pinchart@ideasonboard.com> + - Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> + - Jacopo Mondi <jacopo+renesas@jmondi.org> + +description: |+ + Renesas R-Car color management module connected to R-Car DU video channels. + It provides image enhancement functions such as 1-D look-up tables (LUT), + 3-D look-up tables (CMU), 1D-histogram generation (HGO), and color + space conversion (CSC). + +properties: + compatible: + items: + - enum: + - renesas,r8a7795-cmm + - renesas,r8a7796-cmm + - renesas,r8a77965-cmm + - renesas,r8a77990-cmm + - renesas,r8a77995-cmm + - enum: + - renesas,rcar-gen3-cmm + - renesas,rcar-gen2-cmm + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + resets: + maxItems: 1 + + power-domains: + maxItems: 1 + +required: + - compatible + - reg + - clocks + - resets + - power-domains + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/r8a7796-cpg-mssr.h> + #include <dt-bindings/power/r8a7796-sysc.h> + + cmm0: cmm@fea40000 { + compatible = "renesas,r8a7796-cmm"; + reg = <0 0xfea40000 0 0x1000>; + power-domains = <&sysc R8A7796_PD_ALWAYS_ON>; + clocks = <&cpg CPG_MOD 711>; + resets = <&cpg 711>; + }; -- 2.23.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v4 1/9] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation 2019-09-06 13:43 ` [PATCH v4 1/9] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation Jacopo Mondi @ 2019-09-08 11:58 ` Simon Horman 0 siblings, 0 replies; 9+ messages in thread From: Simon Horman @ 2019-09-08 11:58 UTC (permalink / raw) To: Jacopo Mondi Cc: laurent.pinchart, kieran.bingham+renesas, geert, uli, VenkataRajesh.Kalakodima, devicetree, robh+dt, mark.rutland On Fri, Sep 06, 2019 at 03:43:33PM +0200, Jacopo Mondi wrote: > Add device tree bindings documentation for the Renesas R-Car Display > Unit Color Management Module. > > CMM is the image enhancement module available on each R-Car DU video > channel on R-Car Gen2 and Gen3 SoCs (V3H and V3M excluded). > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > --- > .../bindings/display/renesas,cmm.yaml | 64 +++++++++++++++++++ > 1 file changed, 64 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/renesas,cmm.yaml > > diff --git a/Documentation/devicetree/bindings/display/renesas,cmm.yaml b/Documentation/devicetree/bindings/display/renesas,cmm.yaml > new file mode 100644 > index 000000000000..9e5922689cd7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/renesas,cmm.yaml > @@ -0,0 +1,64 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/renesas,cmm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas R-Car Color Management Module (CMM) > + > +maintainers: > + - Laurent Pinchart <laurent.pinchart@ideasonboard.com> > + - Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > + - Jacopo Mondi <jacopo+renesas@jmondi.org> > + > +description: |+ > + Renesas R-Car color management module connected to R-Car DU video channels. > + It provides image enhancement functions such as 1-D look-up tables (LUT), > + 3-D look-up tables (CMU), 1D-histogram generation (HGO), and color > + space conversion (CSC). > + > +properties: > + compatible: > + items: > + - enum: > + - renesas,r8a7795-cmm > + - renesas,r8a7796-cmm > + - renesas,r8a77965-cmm > + - renesas,r8a77990-cmm > + - renesas,r8a77995-cmm > + - enum: > + - renesas,rcar-gen3-cmm > + - renesas,rcar-gen2-cmm Should we continue the long standing practice in .txt bindings for Renesas IP blocks to document briefly the purpose of each compat string? > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - clocks > + - resets > + - power-domains > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/r8a7796-cpg-mssr.h> > + #include <dt-bindings/power/r8a7796-sysc.h> > + > + cmm0: cmm@fea40000 { > + compatible = "renesas,r8a7796-cmm"; Should "renesas,rcar-gen3-cmm" be listed as the secondary compat string here? > + reg = <0 0xfea40000 0 0x1000>; > + power-domains = <&sysc R8A7796_PD_ALWAYS_ON>; > + clocks = <&cpg CPG_MOD 711>; > + resets = <&cpg 711>; > + }; > -- > 2.23.0 > ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-09-18 22:08 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190906135436.10622-1-jacopo+renesas@jmondi.org>
2019-09-06 13:54 ` [PATCH v4 1/9] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation Jacopo Mondi
2019-09-11 19:04 ` Kieran Bingham
2019-09-17 17:55 ` Rob Herring
2019-09-18 22:08 ` Laurent Pinchart
2019-09-06 13:54 ` [PATCH v4 2/9] dt-bindings: display, renesas,du: Document cmms property Jacopo Mondi
2019-09-11 16:06 ` Kieran Bingham
2019-09-17 17:58 ` Rob Herring
[not found] <20190906134341.9879-1-jacopo+renesas@jmondi.org>
2019-09-06 13:43 ` [PATCH v4 1/9] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation Jacopo Mondi
2019-09-08 11:58 ` Simon Horman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).