From: Rob Herring <robh@kernel.org>
To: allen <allen.chen@ite.com.tw>
Cc: Mark Rutland <mark.rutland@arm.com>,
Pi-Hsun Shih <pihsun@chromium.org>,
Jau-Chih Tseng <Jau-Chih.Tseng@ite.com.tw>,
David Airlie <airlied@linux.ie>,
"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
open list <linux-kernel@vger.kernel.org>,
Maxime Ripard <mripard@kernel.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Icenowy Zheng <icenowy@aosc.io>, Shawn Guo <shawnguo@kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: Add binding for IT6505.
Date: Tue, 17 Sep 2019 14:54:58 -0500 [thread overview]
Message-ID: <20190917195458.GA7386@bogus> (raw)
In-Reply-To: <1568259199-5827-2-git-send-email-allen.chen@ite.com.tw>
On Thu, Sep 12, 2019 at 11:32:28AM +0800, allen wrote:
> From: Allen Chen <allen.chen@ite.com.tw>
>
> Add a DT binding documentation for IT6505.
>
> Signed-off-by: Allen Chen <allen.chen@ite.com.tw>
>
Drop the blank line.
> Signed-off-by: Pi-Hsun Shih <pihsun@chromium.org>
>
> ---
> cros-ec does not have an associated driver that uses the standard Linux USB-C driver class.
> extcon is used to model the Type-C connector.(crbug.com/982932)
> ---
> .../bindings/display/bridge/ite,it6505.txt | 28 ++++++++++++++++++++++
> .../devicetree/bindings/vendor-prefixes.yaml | 2 ++
> 2 files changed, 30 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/bridge/ite,it6505.txt
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it6505.txt b/Documentation/devicetree/bindings/display/bridge/ite,it6505.txt
> new file mode 100644
> index 0000000..72da0c4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.txt
> @@ -0,0 +1,28 @@
> +iTE it6505 DP bridge bindings
> +
> +Required properties:
> + - compatible: "ite,it6505"
> + - reg: i2c address of the bridge
> + - ovdd-supply: I/O voltage
> + - pwr18-supply: Core voltage
> + - interrupts: interrupt specifier of INT pin
> + - reset-gpios: gpio specifier of RESET pin
> + - hpd-gpios:
> + Hotplug detect GPIO.
> + Indicates which GPIO should be used for hotplug detection
This belongs in a dp-connector node.
> + - port@[x]: SoC specific port nodes with endpoint definitions as defined
> + in Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt
I assume this bridge works with more than just Mediatek? The port
definitions need to be in terms of what's the data on each port.
> +
> +Example:
> + dp-bridge@5c {
> + compatible = "ite,it6505";
> + interrupts = <152 IRQ_TYPE_EDGE_RISING 152 0>;
> + reg = <0x5c>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&it6505_pins>;
> + ovdd-supply = <&mt6358_vsim1_reg>;
> + pwr18-supply = <&it6505_pp18_reg>;
> + reset-gpios = <&pio 179 1>;
> + hpd-gpios = <&pio 9 0>;
> + extcon = <&usbc_extcon>;
Not documented and deprecated anyways. Use the connector bindings.
> + };
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 967e78c..fb3b643 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -461,6 +461,8 @@ patternProperties:
> description: Intersil
> "^issi,.*":
> description: Integrated Silicon Solutions Inc.
> + "^ite,.*":
> + description: ITE Tech. Inc.
> "^itead,.*":
> description: ITEAD Intelligent Systems Co.Ltd
> "^iwave,.*":
> --
> 1.9.1
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2019-09-17 19:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 3:32 [PATCH v3 0/2] IT6505 cover letter allen
2019-09-12 3:32 ` [PATCH v3 1/2] dt-bindings: Add binding for IT6505 allen
2019-09-17 19:54 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190917195458.GA7386@bogus \
--to=robh@kernel.org \
--cc=Jau-Chih.Tseng@ite.com.tw \
--cc=airlied@linux.ie \
--cc=allen.chen@ite.com.tw \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=icenowy@aosc.io \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mripard@kernel.org \
--cc=pihsun@chromium.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox