Re: [V2, 2/2] media: i2c: Add DW9768 VCM driver

Andy Shevchenko
2019-09-05T10:19:08Z

On Thu, Sep 05, 2019 at 11:21:34AM +0300, Sakari Ailus wrote:
> On Thu, Sep 05, 2019 at 03:21:42PM +0800, dongchun.zhu@mediatek.com wrote:
> > From: Dongchun Zhu <dongchun.zhu@mediatek.com>

> > +static const struct i2c_device_id dw9768_id_table[] = {
> > + { DW9768_NAME, 0 },
> > + { },
>
> Could you drop the I²C ID table?

But why?
It will allow you to instanciate the device from user space.

+Cc: Javier.

Javier, is it needed in new code?

--
With Best Regards,
Andy Shevchenko