From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v2 1/3] memory: Exynos5422: minor fixes in DMC Date: Wed, 18 Sep 2019 20:55:37 +0200 Message-ID: <20190918185537.GA8463@kozik-lap> References: <20190916100704.26692-1-l.luba@partner.samsung.com> <20190916100704.26692-2-l.luba@partner.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20190916100704.26692-2-l.luba@partner.samsung.com> Sender: linux-kernel-owner@vger.kernel.org To: Lukasz Luba Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, b.zolnierkie@samsung.com, kgene@kernel.org, mark.rutland@arm.com, robh+dt@kernel.org, cw00.choi@samsung.com, kyungmin.park@samsung.com, m.szyprowski@samsung.com, s.nawrocki@samsung.com, myungjoo.ham@samsung.com, willy.mh.wolff.ml@gmail.com List-Id: devicetree@vger.kernel.org On Mon, Sep 16, 2019 at 12:07:02PM +0200, Lukasz Luba wrote: > Small fixes for issues captured by static analyzes: > used kfree() insead of devm_kfree() and missing 'static' in the private > function. > Checks which show the issues: > - drivers/memory/samsung/exynos5422-dmc.c:272 exynos5_init_freq_table() > warn: passing devm_ allocated variable to kfree. 'dmc->opp' > - drivers/memory/samsung/exynos5422-dmc.c:736:1: warning: symbol > 'exynos5_dmc_align_init_freq' was not declared. > > Reported-by: Krzysztof Kozlowski > Signed-off-by: Lukasz Luba > --- > drivers/memory/samsung/exynos5422-dmc.c | 4 ++-- Thanks, applied. Best regards, Krzysztof