From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v1 1/9] ASoC: wm8994: Do not register inapplicable controls for WM1811 Date: Thu, 19 Sep 2019 09:38:32 +0200 Message-ID: <20190919073832.GA13195@pi3> References: <20190918104634.15216-1-s.nawrocki@samsung.com> <20190918104634.15216-2-s.nawrocki@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20190918104634.15216-2-s.nawrocki@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Sylwester Nawrocki Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org, ckeepax@opensource.cirrus.com, b.zolnierkie@samsung.com, sbkim73@samsung.com, patches@opensource.cirrus.com, lgirdwood@gmail.com, robh+dt@kernel.org, broonie@kernel.org, linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com List-Id: devicetree@vger.kernel.org On Wed, Sep 18, 2019 at 12:46:26PM +0200, Sylwester Nawrocki wrote: > In case of WM1811 device there are currently being registered controls > referring to registers not existing on that device. > It has been noticed when getting values of "AIF1ADC2 Volume", "AIF1DAC2 > Volume" controls was failing during ALSA state restoring at boot time: > "amixer: Mixer hw:0 load error: Device or resource busy" > > Reading some registers through I2C was failing with EBUSY error and indeed > those registers were not available according to the datasheet. > > To fix this controls not available on WM1811 are moved to a separate array > and registered only for WM8994 and WM8958. > > There are some further differences between WM8994 and WM1811, e.g. registers > 603h, 604h, 605h, which are not covered in this patch. > > Signed-off-by: Sylwester Nawrocki > --- > sound/soc/codecs/wm8994.c | 43 +++++++++++++++++++++++---------------- > 1 file changed, 26 insertions(+), 17 deletions(-) Acked-by: Krzysztof Kozlowski Best regards, Krzysztof