From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
Maciej Falkowski <m.falkowski@samsung.com>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Andrzej Hajda <a.hajda@samsung.com>
Subject: Re: [PATCH v3] dt-bindings: sound: Convert Samsung I2S controller to dt-schema
Date: Fri, 20 Sep 2019 14:43:00 +0200 [thread overview]
Message-ID: <20190920124300.GA26917@pi3> (raw)
In-Reply-To: <68ec938a-29b5-0c07-3a5e-771d6ce587b4@samsung.com>
On Fri, Sep 20, 2019 at 02:33:13PM +0200, Marek Szyprowski wrote:
> Hi Krzysztof,
>
>> +examples:
> >> + - |
> >> + #include <dt-bindings/clock/exynos-audss-clk.h>
> > Does it really work? When I tried, it was failing... If you look up at
> > resulting DTS example it is wrong.
>
> In which way it was wrong? We checked and it was correctly propagated to
> the example dts. It also compiled fine without errors. The only minor
> issue was that the include was generated inside the root node, but for
> the clock definitions this doesn't matter, but it makes the example
> easier to understand.
Hmmm.... indeed this works. The output DTS is weird as include goes to
example node (not even root) but it compiles. Somehow my previous tries
with it were failing, I need to check why. In general I am all in for
this include.
Best regards,
Krzysztof
next prev parent reply other threads:[~2019-09-20 12:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190917111420eucas1p1f4c9fc370f501b1ec1e2d2fb4299db96@eucas1p1.samsung.com>
2019-09-17 11:14 ` [PATCH 1/2] dt-bindings: sound: Convert Samsung I2S controller to dt-schema Maciej Falkowski
2019-09-17 11:14 ` [PATCH 2/2] dt-bindings: sound: Convert Samsung SMDK audio complex Maciej Falkowski
2019-09-17 12:04 ` [PATCH v2 1/2] dt-bindings: sound: Convert Samsung I2S controller to dt-schema Maciej Falkowski
2019-09-17 12:49 ` Sylwester Nawrocki
2019-09-17 13:05 ` Rob Herring
2019-09-18 10:08 ` Maciej Falkowski
2019-09-18 13:49 ` Rob Herring
2019-09-20 11:35 ` [PATCH v3] " Marek Szyprowski
2019-09-20 12:26 ` Krzysztof Kozlowski
2019-09-20 12:33 ` Marek Szyprowski
2019-09-20 12:43 ` Krzysztof Kozlowski [this message]
2019-09-20 12:27 ` Sylwester Nawrocki
2019-09-20 12:14 ` [PATCH 1/2] ARM: dts: exynos: split phandle in dmas property Marek Szyprowski
2019-09-20 12:14 ` [PATCH 2/2] arm64: " Marek Szyprowski
2019-10-01 19:14 ` Krzysztof Kozlowski
2019-09-20 12:28 ` [PATCH 1/2] ARM: " Krzysztof Kozlowski
2019-10-02 15:49 ` Krzysztof Kozlowski
2019-09-17 12:06 ` [PATCH v2 2/2] dt-bindings: sound: Convert Samsung SMDK audio complex Maciej Falkowski
2019-09-17 14:15 ` Rob Herring
2019-09-18 11:15 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190920124300.GA26917@pi3 \
--to=krzk@kernel.org \
--cc=a.hajda@samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.falkowski@samsung.com \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).