From: Thierry Reding <thierry.reding@gmail.com>
To: Sam Shih <sam.shih@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Ryder Lee <ryder.lee@mediatek.com>,
John Crispin <john@phrozen.org>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v9 07/11] dt-bindings: pwm: pwm-mediatek: add a property "num-pwms"
Date: Sat, 21 Sep 2019 02:21:49 +0200 [thread overview]
Message-ID: <20190921002149.GB86019@mithrandir> (raw)
In-Reply-To: <1568933351-8584-8-git-send-email-sam.shih@mediatek.com>
[-- Attachment #1: Type: text/plain, Size: 1090 bytes --]
On Fri, Sep 20, 2019 at 06:49:07AM +0800, Sam Shih wrote:
> From: Ryder Lee <ryder.lee@mediatek.com>
>
> This adds a property "num-pwms" in example so that we could
> specify the number of PWM channels via device tree.
>
> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> Signed-off-by: Sam Shih <sam.shih@mediatek.com>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Changes since v6:
> Follow reviewers's comments:
> - The subject should indicate this is for Mediatek
>
> Changes since v5:
> - Add an Acked-by tag
> - This file is original v4 patch 5/10
> (https://patchwork.kernel.org/patch/11102577/)
>
> ---
> Documentation/devicetree/bindings/pwm/pwm-mediatek.txt | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
You failed to address Rob's questions repeatedly and I agree with him
that you can just as easily derive the number of PWMs from the specific
compatible string. I won't be applying this and none of the patches that
depend on it.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-09-21 0:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 22:49 [PATCH v9 0/11] Add mt7629 and fix mt7628 pwm Sam Shih
2019-09-19 22:49 ` [PATCH v9 01/11] pwm: mediatek: add a property "num-pwms" Sam Shih
2019-09-19 22:49 ` [PATCH v9 02/11] pwm: mediatek: droping the check for of_device_get_match_data Sam Shih
2019-09-19 22:49 ` [PATCH v9 03/11] pwm: mediatek: remove a property "has-clks" Sam Shih
2019-09-25 6:30 ` Uwe Kleine-König
2019-09-25 7:51 ` Thierry Reding
2019-09-19 22:49 ` [PATCH v9 04/11] pwm: mediatek: allocate the clks array dynamically Sam Shih
2019-09-19 22:49 ` [PATCH v9 05/11] pwm: mediatek: use pwm_mediatek as common prefix Sam Shih
2019-09-19 22:49 ` [PATCH v9 06/11] pwm: mediatek: update license and switch to SPDX tag Sam Shih
2019-09-19 22:49 ` [PATCH v9 07/11] dt-bindings: pwm: pwm-mediatek: add a property "num-pwms" Sam Shih
2019-09-21 0:21 ` Thierry Reding [this message]
2019-09-23 3:20 ` Sam Shih
2019-09-23 13:36 ` Thierry Reding
2019-09-23 15:11 ` Sam Shih
2019-09-23 15:20 ` Thierry Reding
[not found] ` <1568933351-8584-1-git-send-email-sam.shih-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2019-09-19 22:49 ` [PATCH v9 08/11] arm64: dts: mt7622: add a property "num-pwms" for PWM Sam Shih
2019-09-19 22:49 ` [PATCH v9 09/11] arm: dts: mt7623: " Sam Shih
2019-09-19 22:49 ` [PATCH v9 10/11] dt-bindings: pwm: update bindings for MT7629 SoC Sam Shih
2019-09-19 22:49 ` [PATCH v9 11/11] arm: dts: mediatek: add mt7629 pwm support Sam Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190921002149.GB86019@mithrandir \
--to=thierry.reding@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=ryder.lee@mediatek.com \
--cc=sam.shih@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).