From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurentiu Palcu Subject: Re: Re: [PATCH 5/5] arm64: dts: imx8mq: add DCSS node Date: Tue, 24 Sep 2019 07:29:46 +0000 Message-ID: <20190924072945.GB25260@fsr-ub1664-121> References: <1569248002-2485-1-git-send-email-laurentiu.palcu@nxp.com> <1569248002-2485-6-git-send-email-laurentiu.palcu@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Content-Language: en-US Content-ID: Sender: linux-kernel-owner@vger.kernel.org To: Fabio Estevam Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , dl-linux-imx , =?iso-8859-1?Q?Guido_G=FCnther?= , Lucas Stach , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-kernel List-Id: devicetree@vger.kernel.org Hi Fabio, On Mon, Sep 23, 2019 at 01:12:42PM -0300, Fabio Estevam wrote: > Hi Laurentiu, >=20 > On Mon, Sep 23, 2019 at 11:14 AM Laurentiu Palcu > wrote: >=20 > > + > > + dcss: dcss@0x32e00000 { >=20 > Node names should be generic, so: >=20 > dcss: display-controller@32e00000 fair enough, done. >=20 > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + compatible =3D "nxp,imx8mq-dcss"; > > + reg =3D <0x32e00000 0x2D000>, <0x32e2f0= 00 0x1000>; >=20 > 0x2d000 for consistency. will change this as well. Thanks, laurentiu >=20 > > + interrupts =3D <6>, <8>, <9>; >=20 > The interrupts are passed in the format= .=