* [PATCH 2/3] dt-bindings: serial: document LiteUART bindings
@ 2019-09-30 13:04 Mateusz Holenko
2019-09-30 21:32 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Mateusz Holenko @ 2019-09-30 13:04 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Mark Rutland, linux-serial,
devicetree
Cc: Karol Gugala, Mateusz Holenko, Jiri Slaby, linux-kernel,
Maxime Ripard, Shawn Guo, Heiko Stuebner, Sam Ravnborg,
Laurent Pinchart, Icenowy Zheng, Mauro Carvalho Chehab,
David S. Miller, Paul E. McKenney
From: Filip Kokosinski <fkokosinski@internships.antmicro.com>
Add documentation for LiteUART devicetree bindings.
Signed-off-by: Filip Kokosinski <fkokosinski@internships.antmicro.com>
Signed-off-by: Mateusz Holenko <mholenko@antmicro.com>
---
.../devicetree/bindings/serial/litex,liteuart.txt | 12 ++++++++++++
MAINTAINERS | 6 ++++++
2 files changed, 18 insertions(+)
create mode 100644 Documentation/devicetree/bindings/serial/litex,liteuart.txt
diff --git a/Documentation/devicetree/bindings/serial/litex,liteuart.txt b/Documentation/devicetree/bindings/serial/litex,liteuart.txt
new file mode 100644
index 000000000..13c71a0c9
--- /dev/null
+++ b/Documentation/devicetree/bindings/serial/litex,liteuart.txt
@@ -0,0 +1,12 @@
+LiteUART serial controller
+
+Required properties:
+- compatible: should be "litex,liteuart"
+- reg: base address and length of the register set for this device
+
+Example:
+
+uart0: serial@f0001000 {
+ compatible = "litex,liteuart";
+ reg = <0xe0001800 0x100>;
+};
diff --git a/MAINTAINERS b/MAINTAINERS
index b2326dece..65a6cf296 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9462,6 +9462,12 @@ F: Documentation/misc-devices/lis3lv02d.rst
F: drivers/misc/lis3lv02d/
F: drivers/platform/x86/hp_accel.c
+LITEX PLATFORM
+M: Karol Gugala <kgugala@antmicro.com>
+M: Mateusz Holenko <mholenko@antmicro.com>
+S: Maintained
+F: Documentation/devicetree/bindings/serial/litex,liteuart.txt
+
LIVE PATCHING
M: Josh Poimboeuf <jpoimboe@redhat.com>
M: Jiri Kosina <jikos@kernel.org>
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 2/3] dt-bindings: serial: document LiteUART bindings
2019-09-30 13:04 [PATCH 2/3] dt-bindings: serial: document LiteUART bindings Mateusz Holenko
@ 2019-09-30 21:32 ` Rob Herring
2019-10-03 9:23 ` Mateusz Holenko
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2019-09-30 21:32 UTC (permalink / raw)
To: Mateusz Holenko
Cc: Greg Kroah-Hartman, Mark Rutland, open list:SERIAL DRIVERS,
devicetree, Karol Gugala, Jiri Slaby,
linux-kernel@vger.kernel.org, Maxime Ripard, Shawn Guo,
Heiko Stuebner, Sam Ravnborg, Laurent Pinchart, Icenowy Zheng,
Mauro Carvalho Chehab, David S. Miller, Paul E. McKenney
On Mon, Sep 30, 2019 at 8:04 AM Mateusz Holenko <mholenko@antmicro.com> wrote:
>
> From: Filip Kokosinski <fkokosinski@internships.antmicro.com>
>
> Add documentation for LiteUART devicetree bindings.
>
> Signed-off-by: Filip Kokosinski <fkokosinski@internships.antmicro.com>
> Signed-off-by: Mateusz Holenko <mholenko@antmicro.com>
> ---
> .../devicetree/bindings/serial/litex,liteuart.txt | 12 ++++++++++++
> MAINTAINERS | 6 ++++++
> 2 files changed, 18 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/serial/litex,liteuart.txt
Please make this a schema. See
Documentation/devicetree/writing-schema.rst (or .md before 5.4).
>
> diff --git a/Documentation/devicetree/bindings/serial/litex,liteuart.txt b/Documentation/devicetree/bindings/serial/litex,liteuart.txt
> new file mode 100644
> index 000000000..13c71a0c9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/serial/litex,liteuart.txt
> @@ -0,0 +1,12 @@
> +LiteUART serial controller
> +
> +Required properties:
> +- compatible: should be "litex,liteuart"
Only 1 version?
> +- reg: base address and length of the register set for this device
Is there really no interrupt line? That should be added if there's h/w
support even if the driver doesn't yet support it.
> +
> +Example:
> +
> +uart0: serial@f0001000 {
Wrong unit address. Should be "@e0001800".
> + compatible = "litex,liteuart";
> + reg = <0xe0001800 0x100>;
> +};
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b2326dece..65a6cf296 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -9462,6 +9462,12 @@ F: Documentation/misc-devices/lis3lv02d.rst
> F: drivers/misc/lis3lv02d/
> F: drivers/platform/x86/hp_accel.c
>
> +LITEX PLATFORM
> +M: Karol Gugala <kgugala@antmicro.com>
> +M: Mateusz Holenko <mholenko@antmicro.com>
> +S: Maintained
> +F: Documentation/devicetree/bindings/serial/litex,liteuart.txt
> +
> LIVE PATCHING
> M: Josh Poimboeuf <jpoimboe@redhat.com>
> M: Jiri Kosina <jikos@kernel.org>
> --
> 2.23.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 2/3] dt-bindings: serial: document LiteUART bindings
2019-09-30 21:32 ` Rob Herring
@ 2019-10-03 9:23 ` Mateusz Holenko
0 siblings, 0 replies; 3+ messages in thread
From: Mateusz Holenko @ 2019-10-03 9:23 UTC (permalink / raw)
To: Rob Herring
Cc: Greg Kroah-Hartman, Mark Rutland, open list:SERIAL DRIVERS,
devicetree, Karol Gugala, Jiri Slaby,
linux-kernel@vger.kernel.org, Maxime Ripard, Shawn Guo,
Heiko Stuebner, Sam Ravnborg, Laurent Pinchart, Icenowy Zheng,
Mauro Carvalho Chehab, David S. Miller, Paul E. McKenney
pon., 30 wrz 2019 o 23:32 Rob Herring <robh+dt@kernel.org> napisał(a):
>
> On Mon, Sep 30, 2019 at 8:04 AM Mateusz Holenko <mholenko@antmicro.com> wrote:
> >
> > From: Filip Kokosinski <fkokosinski@internships.antmicro.com>
> >
> > Add documentation for LiteUART devicetree bindings.
> >
> > Signed-off-by: Filip Kokosinski <fkokosinski@internships.antmicro.com>
> > Signed-off-by: Mateusz Holenko <mholenko@antmicro.com>
> > ---
> > .../devicetree/bindings/serial/litex,liteuart.txt | 12 ++++++++++++
> > MAINTAINERS | 6 ++++++
> > 2 files changed, 18 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/serial/litex,liteuart.txt
>
> Please make this a schema. See
> Documentation/devicetree/writing-schema.rst (or .md before 5.4).
Ok. We will rewrite it.
> >
> > diff --git a/Documentation/devicetree/bindings/serial/litex,liteuart.txt b/Documentation/devicetree/bindings/serial/litex,liteuart.txt
> > new file mode 100644
> > index 000000000..13c71a0c9
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/serial/litex,liteuart.txt
> > @@ -0,0 +1,12 @@
> > +LiteUART serial controller
> > +
> > +Required properties:
> > +- compatible: should be "litex,liteuart"
>
> Only 1 version?
For the time being there is only one flavor.
> > +- reg: base address and length of the register set for this device
>
> Is there really no interrupt line? That should be added if there's h/w
> support even if the driver doesn't yet support it.
>
> > +
> > +Example:
> > +
> > +uart0: serial@f0001000 {
>
> Wrong unit address. Should be "@e0001800".
Right, address should be consistent with the one in 'reg'.
>
> > + compatible = "litex,liteuart";
> > + reg = <0xe0001800 0x100>;
> > +};
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index b2326dece..65a6cf296 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -9462,6 +9462,12 @@ F: Documentation/misc-devices/lis3lv02d.rst
> > F: drivers/misc/lis3lv02d/
> > F: drivers/platform/x86/hp_accel.c
> >
> > +LITEX PLATFORM
> > +M: Karol Gugala <kgugala@antmicro.com>
> > +M: Mateusz Holenko <mholenko@antmicro.com>
> > +S: Maintained
> > +F: Documentation/devicetree/bindings/serial/litex,liteuart.txt
> > +
> > LIVE PATCHING
> > M: Josh Poimboeuf <jpoimboe@redhat.com>
> > M: Jiri Kosina <jikos@kernel.org>
> > --
> > 2.23.0
> >
Thanks for your comments.
I'll address the remarks in V2 of the patchset after receiving a
response on the rest of the patches.
--
Mateusz Holenko
mobile: +48 606 791 789
Antmicro Ltd | www.antmicro.com
Zwierzyniecka 3, 60-813 Poznan, Poland
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-03 9:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-30 13:04 [PATCH 2/3] dt-bindings: serial: document LiteUART bindings Mateusz Holenko
2019-09-30 21:32 ` Rob Herring
2019-10-03 9:23 ` Mateusz Holenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).