devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] regulator: Document "regulator-boot-on" binding more thoroughly
@ 2019-10-01 19:45 Douglas Anderson
  2019-10-04 17:52 ` Applied "regulator: Document "regulator-boot-on" binding more thoroughly" to the regulator tree Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Douglas Anderson @ 2019-10-01 19:45 UTC (permalink / raw)
  To: Mark Brown, Rob Herring
  Cc: Marco Felsch, ckeepax, zhang.chunyan, Douglas Anderson,
	devicetree, Liam Girdwood, linux-kernel, Mark Rutland

The description of "regulator-boot-on" was a little unclear, at least
to me.  Did this property mean that we should turn the regulator on at
boot?  Or perhaps it was intended only to be used for regulators where
we couldn't read the state at bootup to indicate what state we should
assume?  The answer, it turns out, is both [1].

Let's document this.

[1] https://lore.kernel.org/r/20190923181431.GU2036@sirena.org.uk

Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

Changes in v2:
- Don't mention Linux.  Duh.

 Documentation/devicetree/bindings/regulator/regulator.yaml | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/regulator/regulator.yaml b/Documentation/devicetree/bindings/regulator/regulator.yaml
index 02c3043ce419..92ff2e8ad572 100644
--- a/Documentation/devicetree/bindings/regulator/regulator.yaml
+++ b/Documentation/devicetree/bindings/regulator/regulator.yaml
@@ -38,7 +38,12 @@ properties:
     type: boolean
 
   regulator-boot-on:
-    description: bootloader/firmware enabled regulator
+    description: bootloader/firmware enabled regulator.
+      It's expected that this regulator was left on by the bootloader.
+      If the bootloader didn't leave it on then OS should turn it on
+      at boot but shouldn't prevent it from being turned off later.
+      This property is intended to only be used for regulators where
+      software cannot read the state of the regulator.
     type: boolean
 
   regulator-allow-bypass:
-- 
2.23.0.444.g18eeb5a265-goog

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-10-04 17:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-01 19:45 [PATCH v2] regulator: Document "regulator-boot-on" binding more thoroughly Douglas Anderson
2019-10-04 17:52 ` Applied "regulator: Document "regulator-boot-on" binding more thoroughly" to the regulator tree Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).