From mboxrd@z Thu Jan 1 00:00:00 1970 From: Corentin Labbe Subject: Re: [PATCH v2 05/11] ARM: dts: sun8i: H3: Add Crypto Engine node Date: Wed, 2 Oct 2019 10:44:04 +0200 Message-ID: <20191002084404.GA3101@Red> References: <20191001184141.27956-1-clabbe.montjoie@gmail.com> <20191001184141.27956-6-clabbe.montjoie@gmail.com> <20191002060214.bu67nkd3y6puknrb@gilmour> Reply-To: clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <20191002060214.bu67nkd3y6puknrb@gilmour> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Maxime Ripard Cc: catalin.marinas-5wv7dgnIgG8@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org, linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, wens-jdAy2FN1RRM@public.gmane.org, will-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org On Wed, Oct 02, 2019 at 08:02:14AM +0200, Maxime Ripard wrote: > On Tue, Oct 01, 2019 at 08:41:35PM +0200, Corentin Labbe wrote: > > The Crypto Engine is a hardware cryptographic accelerator that supports > > many algorithms. > > It could be found on most Allwinner SoCs. > > > > This patch enables the Crypto Engine on the Allwinner H3 SoC Device-tree. > > > > Signed-off-by: Corentin Labbe > > --- > > arch/arm/boot/dts/sun8i-h3.dtsi | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi > > index e37c30e811d3..778a23a794c9 100644 > > --- a/arch/arm/boot/dts/sun8i-h3.dtsi > > +++ b/arch/arm/boot/dts/sun8i-h3.dtsi > > @@ -153,6 +153,17 @@ > > allwinner,sram = <&ve_sram 1>; > > }; > > > > + crypto: crypto@1c15000 { > > + compatible = "allwinner,sun8i-h3-crypto"; > > + reg = <0x01c15000 0x1000>; > > + interrupts = ; > > + interrupt-names = "ce_ns"; > > That's not documented in the binding (and I guess unnecessary) > Hello Yes this should be removed. > > + resets = <&ccu RST_BUS_CE>; > > + reset-names = "bus"; > > + clocks = <&ccu CLK_BUS_CE>, <&ccu CLK_CE>; > > + clock-names = "bus", "mod"; > > Nit: we put the clocks before the resets usually > Will do it. Thanks Regards