From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH v6 3/3] PCI: layerscape: Add LS1028a support Date: Thu, 3 Oct 2019 17:10:33 +0800 Message-ID: <20191003091019.GB22491@X250> References: <20190902034319.14026-1-xiaowei.bao@nxp.com> <20190902034319.14026-3-xiaowei.bao@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190902034319.14026-3-xiaowei.bao@nxp.com> Sender: linux-kernel-owner@vger.kernel.org To: Xiaowei Bao Cc: robh+dt@kernel.org, mark.rutland@arm.com, leoyang.li@nxp.com, minghuan.Lian@nxp.com, mingkai.hu@nxp.com, roy.zang@nxp.com, lorenzo.pieralisi@arm.com, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, bhelgaas@google.com, Hou Zhiqiang List-Id: devicetree@vger.kernel.org On Mon, Sep 02, 2019 at 11:43:19AM +0800, Xiaowei Bao wrote: > Add support for the LS1028a PCIe controller. > > Signed-off-by: Xiaowei Bao > Signed-off-by: Hou Zhiqiang > --- > v2: > - No change. > v3: > - Reuse the ls2088 driver data structurt. > v4: > - No change. > v5: > - No change. > v6: > - No change. > > drivers/pci/controller/dwc/pci-layerscape.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c > index 3a5fa26..f24f79a 100644 > --- a/drivers/pci/controller/dwc/pci-layerscape.c > +++ b/drivers/pci/controller/dwc/pci-layerscape.c > @@ -263,6 +263,7 @@ static const struct ls_pcie_drvdata ls2088_drvdata = { > static const struct of_device_id ls_pcie_of_match[] = { > { .compatible = "fsl,ls1012a-pcie", .data = &ls1046_drvdata }, > { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata }, > + { .compatible = "fsl,ls1028a-pcie", .data = &ls2088_drvdata }, I think you can save this driver change by using "fsl,ls2088a-pcie" as compatible fallback like below. compatible = "fsl,ls1028a-pcie", "fsl,ls2088a-pcie"; Shawn > { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata }, > { .compatible = "fsl,ls1046a-pcie", .data = &ls1046_drvdata }, > { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata }, > -- > 2.9.5 >