From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manivannan Sadhasivam Subject: Re: [PATCH v4 2/2] media: i2c: Add IMX290 CMOS image sensor driver Date: Fri, 4 Oct 2019 15:49:02 +0530 Message-ID: <20191004101902.GA19685@mani> References: <20191003095503.12614-1-manivannan.sadhasivam@linaro.org> <20191003095503.12614-3-manivannan.sadhasivam@linaro.org> <20191004092336.GL896@valkosipuli.retiisi.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20191004092336.GL896@valkosipuli.retiisi.org.uk> Sender: linux-kernel-owner@vger.kernel.org To: Sakari Ailus Cc: mchehab@kernel.org, robh+dt@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, c.barrett@framos.com, a.brela@framos.com List-Id: devicetree@vger.kernel.org Hi Sakari, On Fri, Oct 04, 2019 at 12:23:36PM +0300, Sakari Ailus wrote: > Hi Manivannan, > > On Thu, Oct 03, 2019 at 03:25:03PM +0530, Manivannan Sadhasivam wrote: > > Add driver for Sony IMX290 CMOS image sensor driver. The driver only > > supports I2C interface for programming and MIPI CSI-2 for sensor output. > > > > Signed-off-by: Manivannan Sadhasivam > > Could you remove the unneeded ret variable from imx290_power_on() and > unneeded goto in the same function? > yep, sure. > The MAINTAINERS entry belongs to the first patch adding new files. > You mean the bindings patch? If then, sorry no. Usually the devicetree bindings belongs to a separate patch and that is what perferred by Rob. I prefer the MAINTAINERS entry in a separate patch but I've seen subsystems maintainers asking to squash it with the driver patch. But squashing it with bindings patch seems weird to me. Thanks, Mani > Then I think this is good. > > -- > Regards, > > Sakari Ailus