From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com
Subject: Re: [PATCH v3 3/3] mfd: madera: Add support for requesting the supply clocks
Date: Fri, 4 Oct 2019 15:21:34 +0000 [thread overview]
Message-ID: <20191004152134.GA31391@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <20191004143410.GJ18429@dell>
On Fri, Oct 04, 2019 at 03:34:10PM +0100, Lee Jones wrote:
> On Tue, 01 Oct 2019, Charles Keepax wrote:
>
> > Add the ability to get the clock for each clock input pin of the chip
> > and enable MCLK2 since that is expected to be a permanently enabled
> > 32kHz clock.
> >
> > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> > ---
> > /* Init 32k clock sourced from MCLK2 */
> > + ret = clk_prepare_enable(madera->mclk[MADERA_MCLK2].clk);
> > + if (ret != 0) {
>
> Nit: Why is this not 'if (ret)' like in the rest of the file?
>
Apologies will get that fixed up.
Thanks,
Charles
next prev parent reply other threads:[~2019-10-04 15:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 13:46 [PATCH 1/3] mfd: wm8998: Remove some unused registers Charles Keepax
2019-10-01 13:46 ` [PATCH v3 2/3] mfd: madera: Update DT binding document to support clock supplies Charles Keepax
2019-10-01 13:46 ` [PATCH v3 3/3] mfd: madera: Add support for requesting the supply clocks Charles Keepax
2019-10-04 14:34 ` Lee Jones
2019-10-04 15:21 ` Charles Keepax [this message]
2019-10-04 14:47 ` [PATCH 1/3] mfd: wm8998: Remove some unused registers Andrew F. Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191004152134.GA31391@ediswmail.ad.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=patches@opensource.cirrus.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).