From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH v6 4/4] net: phy: realtek: Add LED configuration support for RTL8211E Date: Mon, 7 Oct 2019 13:02:39 +0200 Message-ID: <20191007110239.GA21484@amd> References: <20190813191147.19936-1-mka@chromium.org> <20190813191147.19936-5-mka@chromium.org> <20190816201342.GB1646@bug> <20190816212728.GW250418@google.com> <20190817140502.GA5878@amd> <20190819003757.GB8981@lunn.ch> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="WIyZ46R2i8wDzkSu" Return-path: Content-Disposition: inline In-Reply-To: <20190819003757.GB8981@lunn.ch> Sender: linux-kernel-owner@vger.kernel.org To: Andrew Lunn Cc: Matthias Kaehlcke , jacek.anaszewski@gmail.com, linux-leds@vger.kernel.org, dmurphy@ti.com, "David S . Miller" , Rob Herring , Mark Rutland , Florian Fainelli , Heiner Kallweit , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Douglas Anderson List-Id: devicetree@vger.kernel.org --WIyZ46R2i8wDzkSu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon 2019-08-19 02:37:57, Andrew Lunn wrote: > > Yes, I believe the integration is neccessary. Using same binding is > > neccessary for that, but not sufficient. For example, we need > > compatible trigger names, too. >=20 > Hi Pavel >=20 > Please could you explain what you mean by compatible trigger names? Well, you attempted to put trigger names in device tree. That means those names should work w.r.t. LED subsystem, too. > > So... I'd really like to see proper integration is possible before we > > merge this. >=20 > Please let me turn that around. What do you see as being impossible at > the moment? What do we need to convince you about? That locking requirements are compatible, that triggers you invented can be implemented by LED subsystem, ... Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --WIyZ46R2i8wDzkSu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl2bG08ACgkQMOfwapXb+vLTsACguaZUSA7o5wiU8LUngEzV9LZ2 S4QAoIuXQiHHVs6amdFdbIvXRo7LFifl =yXXm -----END PGP SIGNATURE----- --WIyZ46R2i8wDzkSu--