From: Shawn Guo <shawnguo@kernel.org>
To: Wen He <wen.he_1@nxp.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Li Yang <leoyang.li@nxp.com>,
linux-devel@linux.nxdi.nxp.com, Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [v2 1/2] arm64: dts: ls1028a: Update the clock providers for the Mali DP500
Date: Mon, 7 Oct 2019 20:32:07 +0800 [thread overview]
Message-ID: <20191007123203.GL7150@dragon> (raw)
In-Reply-To: <20190920083419.5092-1-wen.he_1@nxp.com>
On Fri, Sep 20, 2019 at 04:34:18PM +0800, Wen He wrote:
> In order to maximise performance of the LCD Controller's 64-bit AXI
> bus, for any give speed bin of the device, the AXI master interface
> clock(ACLK) clock can be up to CPU_frequency/2, which is already
> capable of optimal performance. In general, ACLK is always expected
> to be equal to CPU_frequency/2. APB slave interface clock(PCLK) and
> Main processing clock(PCLK) both are tied to the same clock as ACLK.
>
> This change followed the LS1028A Architecture Specification Manual.
>
> Signed-off-by: Wen He <wen.he_1@nxp.com>
@Leo, agree?
Shawn
> ---
> change in v2:
> - add details commit description for this change.
> - v1: Link: https://lore.kernel.org/patchwork/patch/1119145/
>
> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 17 ++---------------
> 1 file changed, 2 insertions(+), 15 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 72b9a75976a1..51fa8f57fdac 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -86,20 +86,6 @@
> clocks = <&osc_27m>;
> };
>
> - aclk: clock-axi {
> - compatible = "fixed-clock";
> - #clock-cells = <0>;
> - clock-frequency = <650000000>;
> - clock-output-names= "aclk";
> - };
> -
> - pclk: clock-apb {
> - compatible = "fixed-clock";
> - #clock-cells = <0>;
> - clock-frequency = <650000000>;
> - clock-output-names= "pclk";
> - };
> -
> reboot {
> compatible ="syscon-reboot";
> regmap = <&dcfg>;
> @@ -679,7 +665,8 @@
> interrupts = <0 222 IRQ_TYPE_LEVEL_HIGH>,
> <0 223 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-names = "DE", "SE";
> - clocks = <&dpclk 0>, <&aclk>, <&aclk>, <&pclk>;
> + clocks = <&dpclk 0>, <&clockgen 2 2>, <&clockgen 2 2>,
> + <&clockgen 2 2>;
> clock-names = "pxlclk", "mclk", "aclk", "pclk";
> arm,malidp-output-port-lines = /bits/ 8 <8 8 8>;
> arm,malidp-arqos-value = <0xd000d000>;
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-10-07 12:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 8:34 [v2 1/2] arm64: dts: ls1028a: Update the clock providers for the Mali DP500 Wen He
2019-09-20 8:34 ` [v2 2/2] arm64: dts: ls1028a: Update the DT node definition for dpclk Wen He
2019-10-07 12:35 ` Shawn Guo
2019-10-08 4:08 ` [EXT] " Wen He
2019-10-14 6:21 ` Shawn Guo
2019-10-14 6:25 ` Wen He
2019-10-07 12:32 ` Shawn Guo [this message]
2019-10-07 21:29 ` [v2 1/2] arm64: dts: ls1028a: Update the clock providers for the Mali DP500 Leo Li
2019-10-14 6:19 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191007123203.GL7150@dragon \
--to=shawnguo@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-devel@linux.nxdi.nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=wen.he_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).