devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Wen He <wen.he_1@nxp.com>
Cc: linux-devel@linux.nxdi.nxp.com, Li Yang <leoyang.li@nxp.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [v2 2/2] arm64: dts: ls1028a: Update the DT node definition for dpclk
Date: Mon, 7 Oct 2019 20:35:14 +0800	[thread overview]
Message-ID: <20191007123512.GM7150@dragon> (raw)
In-Reply-To: <20190920083419.5092-2-wen.he_1@nxp.com>

On Fri, Sep 20, 2019 at 04:34:19PM +0800, Wen He wrote:
> Update DT node name clock-controller to clock-display,

The node name clock-controller is so good, and I do not understand why
you need to change it.

Shawn

> also change
> the property #clock-cells value to zero.
> 
> This update according the feedback of the Display output interface
> clock driver upstream.
> 
> Link: https://lore.kernel.org/patchwork/patch/1113832/
> Signed-off-by: Wen He <wen.he_1@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 51fa8f57fdac..db1e186352d8 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -79,10 +79,10 @@
>  		clock-output-names = "phy_27m";
>  	};
>  
> -	dpclk: clock-controller@f1f0000 {
> +	dpclk: clock-display@f1f0000 {
>  		compatible = "fsl,ls1028a-plldig";
>  		reg = <0x0 0xf1f0000 0x0 0xffff>;
> -		#clock-cells = <1>;
> +		#clock-cells = <0>;
>  		clocks = <&osc_27m>;
>  	};
>  
> @@ -665,7 +665,7 @@
>  		interrupts = <0 222 IRQ_TYPE_LEVEL_HIGH>,
>  			     <0 223 IRQ_TYPE_LEVEL_HIGH>;
>  		interrupt-names = "DE", "SE";
> -		clocks = <&dpclk 0>, <&clockgen 2 2>, <&clockgen 2 2>,
> +		clocks = <&dpclk>, <&clockgen 2 2>, <&clockgen 2 2>,
>  			 <&clockgen 2 2>;
>  		clock-names = "pxlclk", "mclk", "aclk", "pclk";
>  		arm,malidp-output-port-lines = /bits/ 8 <8 8 8>;
> -- 
> 2.17.1
> 

  reply	other threads:[~2019-10-07 12:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-20  8:34 [v2 1/2] arm64: dts: ls1028a: Update the clock providers for the Mali DP500 Wen He
2019-09-20  8:34 ` [v2 2/2] arm64: dts: ls1028a: Update the DT node definition for dpclk Wen He
2019-10-07 12:35   ` Shawn Guo [this message]
2019-10-08  4:08     ` [EXT] " Wen He
2019-10-14  6:21       ` Shawn Guo
2019-10-14  6:25         ` Wen He
2019-10-07 12:32 ` [v2 1/2] arm64: dts: ls1028a: Update the clock providers for the Mali DP500 Shawn Guo
2019-10-07 21:29   ` Leo Li
2019-10-14  6:19 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191007123512.GM7150@dragon \
    --to=shawnguo@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-devel@linux.nxdi.nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=wen.he_1@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).