From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v3 8/8] dt-bindings: Add max12xx SPI ADC series as trivial devices Date: Thu, 10 Oct 2019 15:47:51 -0500 Message-ID: <20191010204751.GA22206@bogus> References: <20191007132657.4190-1-miquel.raynal@bootlin.com> <20191007132657.4190-9-miquel.raynal@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20191007132657.4190-9-miquel.raynal@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org To: Miquel Raynal Cc: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Mark Rutland , devicetree@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni List-Id: devicetree@vger.kernel.org On Mon, Oct 07, 2019 at 03:26:57PM +0200, Miquel Raynal wrote: > Update the compatible list with three Maxim ADCs compatibles. > > Signed-off-by: Miquel Raynal > --- > .../bindings/iio/adc/max1027-adc.txt | 28 +++++++++++++++++++ > .../devicetree/bindings/trivial-devices.yaml | 6 ++++ > 2 files changed, 34 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/max1027-adc.txt Devices are supposed to be documented in one place or the other. So either make max1027-adc.txt a schema or drop it. I'm fine either way. Obviously, trivial-devices.yaml is trivial to add to, but it does leave some ambiguities. Like is an interrupt required, optional or non-existent? What about power supplies? Or what are allowed values for spi-max-frequency. Rob