From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Kemnade Subject: Re: [PATCH v3 2/3] ARM: dts: add Netronix E60K02 board common file Date: Fri, 11 Oct 2019 18:19:38 +0200 Message-ID: <20191011181938.185f2a00@kemnade.info> References: <20191010192357.27884-1-andreas@kemnade.info> <20191010192357.27884-3-andreas@kemnade.info> <20191011065609.6irap7elicatmsgg@pengutronix.de> <20191011094148.1376430e@aktux> <20191011142927.GA11490@bogus> <20191011170147.1b3c4b25@kemnade.info> <20191011152214.v6lq6itwf5lp6j7q@pengutronix.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/xJOdSTuzcipgvT99VuhdzxO"; protocol="application/pgp-signature" Return-path: In-Reply-To: <20191011152214.v6lq6itwf5lp6j7q@pengutronix.de> Sender: linux-kernel-owner@vger.kernel.org To: Marco Felsch Cc: Rob Herring , mark.rutland@arm.com, marex@denx.de, devicetree@vger.kernel.org, andrew.smirnov@gmail.com, shawnguo@kernel.org, s.hauer@pengutronix.de, angus@akkea.ca, linux-kernel@vger.kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, manivannan.sadhasivam@linaro.org, j.neuschaefer@gmx.net, Discussions about the Letux Kernel , festevam@gmail.com, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org --Sig_/xJOdSTuzcipgvT99VuhdzxO Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Fri, 11 Oct 2019 17:22:14 +0200 Marco Felsch wrote: > On 19-10-11 17:05, Andreas Kemnade wrote: > > On Fri, 11 Oct 2019 09:29:27 -0500 > > Rob Herring wrote: > > =20 > > > On Fri, Oct 11, 2019 at 09:41:48AM +0200, Andreas Kemnade wrote: =20 > > > > On Fri, 11 Oct 2019 08:56:09 +0200 > > > > Marco Felsch wrote: > > > > =20 > > > > > Hi Andreas, > > > > >=20 > > > > > On 19-10-10 21:23, Andreas Kemnade wrote: =20 > > > > > > The Netronix board E60K02 can be found some several Ebook-Reade= rs, > > > > > > at least the Kobo Clara HD and the Tolino Shine 3. The board > > > > > > is equipped with different SoCs requiring different pinmuxes. > > > > > >=20 > > > > > > For now the following peripherals are included: > > > > > > - LED > > > > > > - Power Key > > > > > > - Cover (gpio via hall sensor) > > > > > > - RC5T619 PMIC (the kernel misses support for rtc and charger > > > > > > subdevices). > > > > > > - Backlight via lm3630a > > > > > > - Wifi sdio chip detection (mmc-powerseq and stuff) > > > > > >=20 > > > > > > It is based on vendor kernel but heavily reworked due to many > > > > > > changed bindings. > > > > > >=20 > > > > > > Signed-off-by: Andreas Kemnade > > > > > > --- > > > > > > Changes in v3: > > > > > > - better led name > > > > > > - correct memory size > > > > > > - comments about missing devices > > > > > >=20 > > > > > > Changes in v2: > > > > > > - reordered, was 1/3 > > > > > > - moved pinmuxes to their actual users, not the parents > > > > > > of them > > > > > > - removed some already-disabled stuff > > > > > > - minor cleanups =20 > > > > >=20 > > > > > You won't change the muxing, so a this dtsi can be self contained? > > > > > =20 > > > > So you want me to put a big=20 > > > > #if defined(MX6SLL) =20 > > >=20 > > > Not sure what the comment meant, but no, don't do this. C defines in = dts=20 > > > files are for symbolic names for numbers and assembling bitfields and= =20 > > > that's it. =20 > >=20 > > yes, that is also my opinion. For now, there is only one user > > of this .dtsi, but I have another one in preparation. That is the > > reason for splitting things between .dts and .dtsi to avoid such ugly > > ifdefs =20 >=20 > Then IMHO the pnictrl-* entries shouldn't appear in the dsti. >=20 hmm, maybe now I understand your idea: You do not want only to have pinctrl_lm3630a_bl_gpio: lm3630a_bl_gpio_grp { fsl,pins =3D < MX6SLL_PAD_EPDC_PWR_CTRL3__GPIO2_IO10 0x1= 0059 /* HWEN */ >; }; in dts, but also do not have these in .dtsi: pinctrl-names =3D "default"; pinctrl-0 =3D <&pinctrl_lm3630a_bl_gpio>; and instead have in dts: &lm3630a { pinctrl-names =3D "default"; pinctrl-0 =3D <&pinctrl_lm3630a_bl_gpio>; =09 }; just to make sure I get it right before doing the restructuring work. That = way of structuring things did not come to my mind, but then the .dtsi is se= lf-contained. Regards, Andreas --Sig_/xJOdSTuzcipgvT99VuhdzxO Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEPIWxmAFyOaBcwCpFl4jFM1s/ye8FAl2gq5oACgkQl4jFM1s/ ye/5WQ//SImeJwq5R6t0iZb9z5B55KLp97kuzkBviRqa/bWog9G1ceHcKolOMpSj /KnN+y5Ila/ha3ncHAlp0dTUitcVSIVlho5boYhLlSzFRkxRnB0+xPsPOSdil1GG TwhIWKuhokxRH+LrMXfPVfEY+eM+jT3RqXxUml7JDqaia5PUdWPP5nRf2jLK+dee SXOv46TGfWVziN4bbZY05zAbcjUeE5IT4tGJpOqcm2Tfmeci6oRlvHzh+j6/y9LB lAto7x+/EuzrLaaY9nmQgzaKGjKLMwjRANPIIFumx6c9U6yvl4ptglSdBZRGtCTE rT+eGouNQOlG5uuDewl8tYCwDwdrg0wBj879xUr9DPogHeXFW7CMvEcMlTk33/56 FSQ8kzz1hxK84qphq6iJyQjReCqb0H2hDgOxB2yV2q8bWxL0S0MRn1iFJ9RODOqW XCU9EILEsLjQbfjB6EHlvR7Gw6ETL1WJIP25drqpyy09pvCtixtLVfpaYWO18adP nOv27Ah/5rT9NW5OH9kzm1Mt2HR1KxDSuyki3vR4rFFuWRrZlwt99nppAXDbzKqj j6oBOqZkksVhsuw4S6J79ML2qRCbOZghcLyQnA50V9Pk7AQuIA+F85h/HF4p3xt/ WfiBoU3pHAnnyk+Yj1YiRzl/YaOWnm+xb2EQCtPxeyI9qyiDuwk= =7ucO -----END PGP SIGNATURE----- --Sig_/xJOdSTuzcipgvT99VuhdzxO--