* [PATCH 1/1] ARM: dts: imx28: add poweroff support
@ 2019-09-23 9:17 Sébastien Szymanski
2019-10-14 6:38 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Sébastien Szymanski @ 2019-09-23 9:17 UTC (permalink / raw)
To: linux-arm-kernel, devicetree, NXP Linux Team,
Pengutronix Kernel Team
Cc: Mark Rutland, Fabio Estevam, Sascha Hauer, Julien Boibessot,
Rob Herring, Shawn Guo
This add poweroff support using the generic syscon-poweroff driver.
Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
---
arch/arm/boot/dts/imx28.dtsi | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
index e14d8ef0158b..37fa8131a022 100644
--- a/arch/arm/boot/dts/imx28.dtsi
+++ b/arch/arm/boot/dts/imx28.dtsi
@@ -1114,8 +1114,16 @@
};
power: power@80044000 {
+ compatible = "syscon", "simple-mfd";
reg = <0x80044000 0x2000>;
- status = "disabled";
+
+ mxs_poweroff: mxs-poweroff {
+ compatible = "syscon-poweroff";
+ regmap = <&power>;
+ offset = <0x104>;
+ value = <0x3E770001>;
+ status = "disabled";
+ };
};
saif1: saif@80046000 {
--
2.21.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/1] ARM: dts: imx28: add poweroff support
2019-09-23 9:17 [PATCH 1/1] ARM: dts: imx28: add poweroff support Sébastien Szymanski
@ 2019-10-14 6:38 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2019-10-14 6:38 UTC (permalink / raw)
To: Sébastien Szymanski
Cc: Mark Rutland, devicetree, Sascha Hauer, Julien Boibessot,
Rob Herring, NXP Linux Team, Pengutronix Kernel Team,
Fabio Estevam, linux-arm-kernel
On Mon, Sep 23, 2019 at 11:17:00AM +0200, Sébastien Szymanski wrote:
> This add poweroff support using the generic syscon-poweroff driver.
>
> Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
> ---
> arch/arm/boot/dts/imx28.dtsi | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
> index e14d8ef0158b..37fa8131a022 100644
> --- a/arch/arm/boot/dts/imx28.dtsi
> +++ b/arch/arm/boot/dts/imx28.dtsi
> @@ -1114,8 +1114,16 @@
> };
>
> power: power@80044000 {
> + compatible = "syscon", "simple-mfd";
> reg = <0x80044000 0x2000>;
> - status = "disabled";
> +
> + mxs_poweroff: mxs-poweroff {
Node name should be generic. So 'poweroff' might be better.
> + compatible = "syscon-poweroff";
> + regmap = <&power>;
> + offset = <0x104>;
> + value = <0x3E770001>;
Use lowercase for hex value.
> + status = "disabled";
Why need to disable it by default?
Shawn
> + };
> };
>
> saif1: saif@80046000 {
> --
> 2.21.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-14 6:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-23 9:17 [PATCH 1/1] ARM: dts: imx28: add poweroff support Sébastien Szymanski
2019-10-14 6:38 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).