From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>, Chris Snook <chris.snook@gmail.com>,
James Hogan <jhogan@kernel.org>, Jay Cliburn <jcliburn@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Paul Burton <paul.burton@mips.com>,
Ralf Baechle <ralf@linux-mips.org>,
Rob Herring <robh+dt@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Vivien Didelot <vivien.didelot@gmail.com>,
devicetree@vger.kernel.org, netdev@vger.kernel.org,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
Pengutronix Kernel Team <kernel@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v1 4/4] net: dsa: add support for Atheros AR9331 build-in switch
Date: Fri, 18 Oct 2019 06:52:26 +0200 [thread overview]
Message-ID: <20191018045226.hi2nybxkwopclajy@pengutronix.de> (raw)
In-Reply-To: <2ad26bdc-e099-ded6-1337-5793aba0958d@gmail.com>
On Thu, Oct 17, 2019 at 11:35:48AM -0700, Florian Fainelli wrote:
>
>
> On 10/13/2019 11:15 PM, Oleksij Rempel wrote:
> > Provide basic support for Atheros AR9331 build-in switch. So far it
> > works as port multiplexer without any hardware offloading support.
>
> I glanced through the functional parts of the code, and it looks pretty
> straight forward, since there is no offloading done so far, do you plan
> on adding bridge offload eventually if nothing more?
Currently not. There are following reasons:
- I do it for the Freifunk project. It is currently not clear, what
functionality has higher priority.
- there are not many ar9331 based devices with enough RAM to run any
thing modern. There is even less devices using more then one switch
port.
- IPv6 support is important for this project, but old Atheros switches have some
known issues with IPv6 packages in hardware bridge mode. So, this
functionality will need more testing.
> When you submit v2, I would suggest splitting the tagger code from the
> switch driver code, just to make them easier to review.
ok.
Regards,
Oleksij
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2019-10-18 5:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 6:15 [PATCH v1 0/4] add dsa switch support for ar9331 Oleksij Rempel
2019-10-14 6:15 ` [PATCH v1 1/4] net: ag71xx: port to phylink Oleksij Rempel
2019-10-14 6:15 ` [PATCH v1 2/4] dt-bindings: net: dsa: qca,ar9331 switch documentation Oleksij Rempel
2019-10-14 6:15 ` [PATCH v1 3/4] MIPS: ath79: ar9331: add ar9331-switch node Oleksij Rempel
2019-10-14 6:15 ` [PATCH v1 4/4] net: dsa: add support for Atheros AR9331 build-in switch Oleksij Rempel
[not found] ` <2ad26bdc-e099-ded6-1337-5793aba0958d@gmail.com>
2019-10-18 4:52 ` Oleksij Rempel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018045226.hi2nybxkwopclajy@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=andrew@lunn.ch \
--cc=chris.snook@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jcliburn@gmail.com \
--cc=jhogan@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).