Re: [PATCH 5/7 v4] mfd: ab8500: augment DT bindings

Re: [PATCH 5/7 v4] mfd: ab8500: augment DT bindings

[Lee Jones]

On Thu, 17 Oct 2019, Jonathan Cameron wrote:

> On Fri, 11 Oct 2019 08:44:49 -0500
> Rob Herring <robh@kernel.org> wrote:
> 
> > On Fri, Oct 11, 2019 at 09:18:03AM +0200, Linus Walleij wrote:
> > > As we migrate the AB8500 GPADC driver to use IIO, we need to augment
> > > the bindings to account for defining the ADC channels in the device
> > > tree.
> > > 
> > > Cc: devicetree@vger.kernel.org
> > > Acked-by: Lee Jones <lee.jones@linaro.org>
> > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> > > ---
> > > ChangeLog v3->v4:
> > > - Fix the nodenames from "foo_node" to "foo-node"  
> > 
> > You forgot to update the example. With that fixed,
> Given the number of these, I'm not that comfortable just
> fixing this up.  Linus could you do me a follow up patch tiding
> up this detail.
> 
> I don't want to delay the immutable branch any longer and
> would hope the bindings are stable enough that no one will
> need this little update in their tree as well as mfd 
> (or IIO if Lee doesn't pick up the immutable)

Can you change the subject line to start with an uppercase char.

Else my OCD sense will go into overdrive! ;)

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 5/7 v4] mfd: ab8500: augment DT bindings

[Linus Walleij]

On Fri, Oct 18, 2019 at 9:30 AM Lee Jones <lee.jones@linaro.org> wrote:
> On Thu, 17 Oct 2019, Jonathan Cameron wrote:

> Can you change the subject line to start with an uppercase char.
>
> Else my OCD sense will go into overdrive! ;)

Jonathan: it's fine to rebase the immutable branch for this as long as no-one
has pulled it in I suppose.

Working on a binding example cleanup.

Yours,
Linus Walleij

Re: [PATCH 5/7 v4] mfd: ab8500: augment DT bindings

[Jonathan Cameron]

On Fri, 18 Oct 2019 09:48:49 +0200
Linus Walleij <linus.walleij@linaro.org> wrote:

> On Fri, Oct 18, 2019 at 9:30 AM Lee Jones <lee.jones@linaro.org> wrote:
> > On Thu, 17 Oct 2019, Jonathan Cameron wrote:  
> 
> > Can you change the subject line to start with an uppercase char.
> >
> > Else my OCD sense will go into overdrive! ;)  
> 
> Jonathan: it's fine to rebase the immutable branch for this as long as no-one
> has pulled it in I suppose.

True enough.  I'll check the obvious branches and hope nothing else
gets through!

Jonathan


> 
> Working on a binding example cleanup.
> 
> Yours,
> Linus Walleij