Re: [PATCH v4 07/10] ASoC: cros_ec_codec: support WoV

Re: [PATCH v4 07/10] ASoC: cros_ec_codec: support WoV

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 637 bytes --]

On Thu, Oct 17, 2019 at 10:00:12PM +0800, Tzung-Bi Shih wrote:
> 1. Get EC codec's capabilities.
> 2. Get and set SHM address if any.
> 3. Transmit language model to EC codec if needed.
> 4. Start to read audio data from EC codec if receives host event.

This breaks the build:

ld: sound/soc/codecs/cros_ec_codec.o: in function `calculate_sha256.isra.15':
cros_ec_codec.c:(.text+0x119d): undefined reference to `crypto_alloc_shash'
ld: cros_ec_codec.c:(.text+0x11c1): undefined reference to `crypto_shash_digest'
ld: cros_ec_codec.c:(.text+0x11df): undefined reference to `crypto_destroy_tfm'
make: *** [Makefile:1094: vmlinux] Error 1

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v4 07/10] ASoC: cros_ec_codec: support WoV

[Tzung-Bi Shih]

On Sat, Oct 19, 2019 at 1:22 AM Mark Brown <broonie@kernel.org> wrote:
>
> On Thu, Oct 17, 2019 at 10:00:12PM +0800, Tzung-Bi Shih wrote:
> > 1. Get EC codec's capabilities.
> > 2. Get and set SHM address if any.
> > 3. Transmit language model to EC codec if needed.
> > 4. Start to read audio data from EC codec if receives host event.
>
> This breaks the build:
>
> ld: sound/soc/codecs/cros_ec_codec.o: in function `calculate_sha256.isra.15':
> cros_ec_codec.c:(.text+0x119d): undefined reference to `crypto_alloc_shash'
> ld: cros_ec_codec.c:(.text+0x11c1): undefined reference to `crypto_shash_digest'
> ld: cros_ec_codec.c:(.text+0x11df): undefined reference to `crypto_destroy_tfm'
> make: *** [Makefile:1094: vmlinux] Error 1

Thanks so much for pointing this out.  Yeah, I forgot to select
CRYPTO_SHA256 in Kconfig.

Looks like there is a blind point in my local build tests
(allyesconfig, allnoconfig, allmodconfig).  The config in the build
fail case could be "CROS_EC_CODEC=y" and "CRYPTO_*=n".

Could you tell me how you get the .config (to enhance my local build
tests next time)?  I tried randconfig several times but it seems not
easy to hit the case (i.e. CROS_EC_CODEC=y but CRYPTO_*=n).

Re: [PATCH v4 07/10] ASoC: cros_ec_codec: support WoV

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 668 bytes --]

On Sat, Oct 19, 2019 at 02:39:20AM +0800, Tzung-Bi Shih wrote:

> Could you tell me how you get the .config (to enhance my local build
> tests next time)?  I tried randconfig several times but it seems not
> easy to hit the case (i.e. CROS_EC_CODEC=y but CRYPTO_*=n).

That one was caught using merge_config.sh to merge in the config below
then have a script that turns on all options in my subsystems and MFD.

CONFIG_COMPILE_TEST=y
CONFIG_OF=y
CONFIG_I2C=y
CONFIG_SPI=y
CONFIG_REGULATOR=y
CONFIG_SOUND=y
CONFIG_SND=y
CONFIG_SND_SOC=y
CONFIG_SND_SOC_ALL_CODECS=y
CONFIG_SPMI=y
CONFIG_NLS=y
CONFIG_SLIMBUS=y
CONFIG_CLK=y
CONFIG_DMADEVICES=y
CONFIG_PCI=y
CONFIG_ACPI=y

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]