From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alim Akhtar <alim.akhtar@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Kukjin Kim <kgene@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: exynos: Rename children of SysRAM node to "sram"
Date: Mon, 21 Oct 2019 18:21:15 +0200 [thread overview]
Message-ID: <20191021162115.GA21883@kozik-lap> (raw)
In-Reply-To: <CAGOxZ531SdYcud3nQ-6hbCRZptUYznTRajVyxwEi-mFmm8-zPg@mail.gmail.com>
On Mon, Oct 21, 2019 at 09:37:24PM +0530, Alim Akhtar wrote:
> On Mon, Oct 21, 2019 at 8:45 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > The device node name should reflect generic class of a device so rename
> > the children of SysRAM node to "smp-sysram". This will be also in sync
> Typo "smp-sram"
Thanks, indeed.
> > with upcoming DT schema. No functional change.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> Looks good to me.
Shall I add your review-tag?
Best regards,
Krzysztof
>
> > arch/arm/boot/dts/exynos3250.dtsi | 4 ++--
> > arch/arm/boot/dts/exynos4210-universal_c210.dts | 6 +++---
> > arch/arm/boot/dts/exynos4210.dtsi | 4 ++--
> > arch/arm/boot/dts/exynos4412.dtsi | 4 ++--
> > arch/arm/boot/dts/exynos5250.dtsi | 4 ++--
> > arch/arm/boot/dts/exynos54xx.dtsi | 4 ++--
> > 6 files changed, 13 insertions(+), 13 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi
> > index b016b0b68306..044e5da64a76 100644
> > --- a/arch/arm/boot/dts/exynos3250.dtsi
> > +++ b/arch/arm/boot/dts/exynos3250.dtsi
> > @@ -145,12 +145,12 @@
> > #size-cells = <1>;
> > ranges = <0 0x02020000 0x40000>;
> >
> > - smp-sysram@0 {
> > + smp-sram@0 {
> > compatible = "samsung,exynos4210-sysram";
> > reg = <0x0 0x1000>;
> > };
> >
> > - smp-sysram@3f000 {
> > + smp-sram@3f000 {
> > compatible = "samsung,exynos4210-sysram-ns";
> > reg = <0x3f000 0x1000>;
> > };
> > diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts b/arch/arm/boot/dts/exynos4210-universal_c210.dts
> > index 09d3d54d09ff..a1bdf7830a87 100644
> > --- a/arch/arm/boot/dts/exynos4210-universal_c210.dts
> > +++ b/arch/arm/boot/dts/exynos4210-universal_c210.dts
> > @@ -590,16 +590,16 @@
> > };
> >
> > &sysram {
> > - smp-sysram@0 {
> > + smp-sram@0 {
> > status = "disabled";
> > };
> >
> > - smp-sysram@5000 {
> > + smp-sram@5000 {
> > compatible = "samsung,exynos4210-sysram";
> > reg = <0x5000 0x1000>;
> > };
> >
> > - smp-sysram@1f000 {
> > + smp-sram@1f000 {
> > status = "disabled";
> > };
> > };
> > diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi
> > index 554819ae1446..b4466232f0c1 100644
> > --- a/arch/arm/boot/dts/exynos4210.dtsi
> > +++ b/arch/arm/boot/dts/exynos4210.dtsi
> > @@ -79,12 +79,12 @@
> > #size-cells = <1>;
> > ranges = <0 0x02020000 0x20000>;
> >
> > - smp-sysram@0 {
> > + smp-sram@0 {
> > compatible = "samsung,exynos4210-sysram";
> > reg = <0x0 0x1000>;
> > };
> >
> > - smp-sysram@1f000 {
> > + smp-sram@1f000 {
> > compatible = "samsung,exynos4210-sysram-ns";
> > reg = <0x1f000 0x1000>;
> > };
> > diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi
> > index 5022aa574b26..48868947373e 100644
> > --- a/arch/arm/boot/dts/exynos4412.dtsi
> > +++ b/arch/arm/boot/dts/exynos4412.dtsi
> > @@ -195,12 +195,12 @@
> > #size-cells = <1>;
> > ranges = <0 0x02020000 0x40000>;
> >
> > - smp-sysram@0 {
> > + smp-sram@0 {
> > compatible = "samsung,exynos4210-sysram";
> > reg = <0x0 0x1000>;
> > };
> >
> > - smp-sysram@2f000 {
> > + smp-sram@2f000 {
> > compatible = "samsung,exynos4210-sysram-ns";
> > reg = <0x2f000 0x1000>;
> > };
> > diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> > index e1f0215e3985..ec983283f573 100644
> > --- a/arch/arm/boot/dts/exynos5250.dtsi
> > +++ b/arch/arm/boot/dts/exynos5250.dtsi
> > @@ -171,12 +171,12 @@
> > #size-cells = <1>;
> > ranges = <0 0x02020000 0x30000>;
> >
> > - smp-sysram@0 {
> > + smp-sram@0 {
> > compatible = "samsung,exynos4210-sysram";
> > reg = <0x0 0x1000>;
> > };
> >
> > - smp-sysram@2f000 {
> > + smp-sram@2f000 {
> > compatible = "samsung,exynos4210-sysram-ns";
> > reg = <0x2f000 0x1000>;
> > };
> > diff --git a/arch/arm/boot/dts/exynos54xx.dtsi b/arch/arm/boot/dts/exynos54xx.dtsi
> > index f78dee801cd9..8aa5117e58ce 100644
> > --- a/arch/arm/boot/dts/exynos54xx.dtsi
> > +++ b/arch/arm/boot/dts/exynos54xx.dtsi
> > @@ -62,12 +62,12 @@
> > #size-cells = <1>;
> > ranges = <0 0x02020000 0x54000>;
> >
> > - smp-sysram@0 {
> > + smp-sram@0 {
> > compatible = "samsung,exynos4210-sysram";
> > reg = <0x0 0x1000>;
> > };
> >
> > - smp-sysram@53000 {
> > + smp-sram@53000 {
> > compatible = "samsung,exynos4210-sysram-ns";
> > reg = <0x53000 0x1000>;
> > };
> > --
> > 2.17.1
> >
>
>
> --
> Regards,
> Alim
prev parent reply other threads:[~2019-10-21 16:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 15:14 [PATCH] ARM: dts: exynos: Rename children of SysRAM node to "sram" Krzysztof Kozlowski
2019-10-21 16:07 ` Alim Akhtar
2019-10-21 16:21 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021162115.GA21883@kozik-lap \
--to=krzk@kernel.org \
--cc=alim.akhtar@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).